Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on upstream ruamel.yaml instead of unmaintained ruamel_yaml #42

Closed
mbargull opened this issue Nov 2, 2023 · 1 comment · May be fixed by mlund/faunus-feedstock#1
Closed

Depend on upstream ruamel.yaml instead of unmaintained ruamel_yaml #42

mbargull opened this issue Nov 2, 2023 · 1 comment · May be fixed by mlund/faunus-feedstock#1
Labels
enhancement New feature or request

Comments

@mbargull
Copy link
Member

mbargull commented Nov 2, 2023

Comment:

I'm currently looking at what packages on conda-forge have a dependency on the non-maintained ruamel_yaml package.

It'd be good if we could have this package depend on ruamel.yaml instead of ruamel_yaml, too.

NB: The latest conda-forge::ruamel_yaml is still at version 0.15.80 -- upstream released that version 5 years ago.


Faunus uses the PyYAML top-level yaml.safe_load/yaml.safe_dump functions which have been removed in ruamel.yaml=0.18 (see https://pypi.org/project/ruamel.yaml/0.18.4/ for details).
I've issued an upstream PR to use the load/dump methods from ruamel.yaml.YAML(typ="safe") for compatibility with ruamel.yaml=0.18 at mlund/faunus#435 . (Though not tested by me, due to time constraints.)

It may make sense to add an upper bound on the ruamel.yaml dependency with ,<0.19.0a0 with the upstream PR included or ,<0.18.0a0 without.

@mlund
Copy link
Contributor

mlund commented Mar 26, 2024

Closed by #47

@mlund mlund closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants