Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream ruamel.yaml instead of ruamel_yaml #435

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

mbargull
Copy link
Contributor

@mbargull mbargull commented Nov 2, 2023

Description

I'm currently looking at what packages on conda-forge have a dependency on the non-maintained ruamel_yaml package.

It'd be good if we could have this package depend on ruamel.yaml instead of ruamel_yaml, too.

NB: The latest conda-forge::ruamel_yaml is still at version 0.15.80 -- upstream released that version 5 years ago.

Conda-forge will stop (re-)building (the severly outdated) ruamel_yaml package;
tracking issue: conda-forge/ruamel_yaml-feedstock#107

xref: conda-forge/faunus-feedstock#42


This should also add compatibility for ruamel.yaml=0.18.
ruamel.yaml=0.18 removed the top-level load, dump, etc. functions.
For details see https://pypi.org/project/ruamel.yaml/0.18.4/ .


As indicated in the incomplete checklist below, the changes have unfortunately, not been tested by myself.
Feel free to cherry-pick these changes or push to this PR's branch directly (Allow edits by maintainers is enabled) if changes are needed.

Checklist

  • make test passes with no errors

  • the source code is well documented

  • new functionality includes unittests

  • the user-manual has been updated to reflect the changes

  • I have installed the provided commit hook to auto-format commits (requires clang-format):

    ./scripts/git-pre-commit-format install
  • code naming scheme follows the convention:

    Style Elements
    PascalCase classes, namespaces
    camelCase functions
    snake_case variables

The ruamel_yaml package was created by Anaconda as a workaround for
namespace package issues a long time ago.
By now it is not needed anymore and ruamel.yaml is available from
Anaconda's "defaults" channel as well as conda-forge.
Conda-forge will stop (re-)building (the severly outdated) ruamel_yaml
package; tracking issue:
conda-forge/ruamel_yaml-feedstock#107

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
ruamel.yaml=0.18 removed the top-level load, dump, etc. functions.
For details see https://pypi.org/project/ruamel.yaml/0.18.4/ .

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mlund
Copy link
Owner

mlund commented Nov 2, 2023

Thanks for looking into this.

@mbargull
Copy link
Contributor Author

mbargull commented Nov 2, 2023

Thanks for the extremely fast reaction :)

@mbargull mbargull mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants