-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ABI changes #28
Fix ABI changes #28
Conversation
as in fmtlib/fmt#2696 fixes conda-forge#27
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/fmt-feedstock/actions/runs/1654055371. |
Let's wait for the upstream fix to be merged. |
Ok. But we should mark 8.1.0 as broken. (Because it breaks stuff apparently.) |
There will be a patch release. |
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime. The issue has been reported upstream and a patch is waiting to be merged. We might create a patched 8.1.0 build or wait for 8.1.1; the relevant discussion is at conda-forge/fmt-feedstock#28 and fmtlib/fmt#2696. Pinning of fmt is handled by the conda-forge-pinning-feedstock.
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime. The issue has been reported upstream and a patch is waiting to be merged. We might create a patched 8.1.0 build or wait for 8.1.1; the relevant discussion is at conda-forge/fmt-feedstock#28 and fmtlib/fmt#2696. An alternative here would be to patch the repodata and tell the <8.1.0 build to use !=8.1.0_0. However, it does not seem to be the correct approach to me to exclude a single build with a constraint.
I opened conda-forge/admin-requests#367 to mark our 8.1.0 build as broken. |
Ok. We'll wait for the patch release then. |
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime. The issue has been reported upstream and a patch is waiting to be merged. We might create a patched 8.1.0 build or wait for 8.1.1; the relevant discussion is at conda-forge/fmt-feedstock#28 and fmtlib/fmt#2696. An alternative here would be to patch the repodata and tell the <8.1.0 build to use !=8.1.0_0. However, it does not seem to be the correct approach to me to exclude a single build with a constraint.
as in fmtlib/fmt#2696
fixes #27