Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI changes #28

Closed
wants to merge 1 commit into from
Closed

Fix ABI changes #28

wants to merge 1 commit into from

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jan 4, 2022

as in fmtlib/fmt#2696

fixes #27

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum
Copy link
Member Author

saraedum commented Jan 4, 2022

@conda-forge-admin, please rerender.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/fmt-feedstock/actions/runs/1654055371.

@tdegeus
Copy link
Member

tdegeus commented Jan 4, 2022

Let's wait for the upstream fix to be merged.
If it is I would still prefer a patch release upstream. Could you comment @vitaut ?

@saraedum
Copy link
Member Author

saraedum commented Jan 4, 2022

Let's wait for the upstream fix to be merged. If it is I would still prefer a patch release upstream.

Ok. But we should mark 8.1.0 as broken. (Because it breaks stuff apparently.)

@vitaut
Copy link

vitaut commented Jan 4, 2022

There will be a patch release.

saraedum added a commit to saraedum/admin-requests that referenced this pull request Jan 4, 2022
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that
were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime.

The issue has been reported upstream and a patch is waiting to be
merged. We might create a patched 8.1.0 build or wait for 8.1.1; the
relevant discussion is at
conda-forge/fmt-feedstock#28 and
fmtlib/fmt#2696.

Pinning of fmt is handled by the conda-forge-pinning-feedstock.
saraedum added a commit to saraedum/admin-requests that referenced this pull request Jan 4, 2022
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that
were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime.

The issue has been reported upstream and a patch is waiting to be
merged. We might create a patched 8.1.0 build or wait for 8.1.1; the
relevant discussion is at
conda-forge/fmt-feedstock#28 and
fmtlib/fmt#2696.

An alternative here would be to patch the repodata and tell the <8.1.0
build to use !=8.1.0_0. However, it does not seem to be the correct
approach to me to exclude a single build with a constraint.
@saraedum
Copy link
Member Author

saraedum commented Jan 4, 2022

I opened conda-forge/admin-requests#367 to mark our 8.1.0 build as broken.

@saraedum
Copy link
Member Author

saraedum commented Jan 4, 2022

Ok. We'll wait for the patch release then.

@saraedum saraedum closed this Jan 4, 2022
ammattita6i added a commit to ammattita6i/admin-requests that referenced this pull request Aug 14, 2024
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that
were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime.

The issue has been reported upstream and a patch is waiting to be
merged. We might create a patched 8.1.0 build or wait for 8.1.1; the
relevant discussion is at
conda-forge/fmt-feedstock#28 and
fmtlib/fmt#2696.

An alternative here would be to patch the repodata and tell the <8.1.0
build to use !=8.1.0_0. However, it does not seem to be the correct
approach to me to exclude a single build with a constraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined symbol in 8.1 for library built against 8.0
4 participants