Update google-cloud-cpp to v2.11.0 #139
Conversation
…nda-forge-pinning 2023.06.01.18.53.46
dbolduc
requested review from
coryan,
davidbrochart,
h-vetinari and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
That's because you're not a maintainer on this feedstock... yet? ;-) (to do so, add your GH handle in the appropriate section at the end of the |
|
Also, note that this PR doesn't automatically get the newest protobuf version pulled in (that takes extra steps which are currently waiting in a separate PR). So IIUC, we shouldn't yet remove the patch that disables some features, because this build is still against protobuf 3.21. Some short discussion on this with Carlos is in #136 |
Done.
Ah, ok. I now see how the "Rebuild for protobuf423" PRs update the protobuf version in the I rebased the patch. (Maybe I could have included the commits from #137 in this PR, but oh well). |
We don't have to do that manually, that's done by the bot (which can be invoked like If you want we can already pick the relevant commit (6da07f4) into this PR and then rerender. Or we do it in separate PRs (which is perhaps cleaner), no strong feelings. Happy to have you on board! |
| From 20b43fdb677ea76cfcbdf0e4f000158fe99f615d Mon Sep 17 00:00:00 2001 | ||
| From: Carlos O'Ryan <coryan@google.com> | ||
| Date: Tue, 7 Feb 2023 01:35:26 +0000 | ||
| Subject: [PATCH] disable libraries | ||
|
|
||
| --- | ||
| cmake/GoogleCloudCppFeatures.cmake | 6 +++--- | ||
| 1 file changed, 3 insertions(+), 3 deletions(-) | ||
|
|
There was a problem hiding this comment.
We try to keep attribution on patches. Generally git format-patch tags/<x> --no-signature works best (in a branch based on the last release, which can be rebased when the next release comes around).
There was a problem hiding this comment.
I fixed this in #138, also reducing the churn of deleting-and-reinstating the patch.
There was a problem hiding this comment.
I fixed this in #138
Awesome, thanks! I will close this PR.
I could not figure out how to add commits onto #138, so here is a new PR.