-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Preserving the log as azure will delete on push due to the very slow osx agent we caught
|
I managed to get rid of the linkage errors for I tried a bunch of combinations of If you have some insights on that, this would be much appreciated. 🙃 |
@isuruf |
Thanks for the help! Would you have anything against making the name a bit more homogeneous, i.e.
Also: fair warning that I'm going to rebase out my garbage commits. |
On closer inspection, since I don't find |
I think it might be cleaner to override this default from |
Or maybe not override it. In any case, |
I think we're going to need I had it in the bat script before. |
This is so weird to me...
is back now that we're using the by-the-book setup, but it was not an issue when it had just been hardcoded to PS. Link to CI run that just finished |
9cf0256
to
2fe8f8f
Compare
Ah, just noticed that we're in a different lib here still...
And |
recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch
Outdated
Show resolved
Hide resolved
I'm going to try what I had in mind here, but to be clear: I'm very grateful for your help and in no way do I want to be disrespectful by force-pushing over your changes. That's why I opened #246, so we can both iterate without sharing the same PR. |
f5068cb
to
ebced64
Compare
Well, the whole dance around |
@isuruf At least I'm not confident I can shepherd this to completion, the windows symbol export stuff is just excruciating (I've also been really low on FOSS-time recently), and I'm out of ideas after we've now effectively copied the whole
shebang, and it still not working. |
Ping @isuruf, any further thoughts here? Otherwise I think it's time to merge the PR for 1.49 and then start migrating 1.49 (skipping 1.48). We could use 1.50 to iterate on the privatization part. |
recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch
Outdated
Show resolved
Hide resolved
You need to do
around https://github.com/grpc/grpc/blob/v1.48.1/CMakeLists.txt#L4215 |
OK I'll try, thanks a lot! What do you think we should do about Unconditionally set it to False on windows? |
|
recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch
Outdated
Show resolved
Hide resolved
I had a commit with the rename lined up (even though the interaction is not clear to me), but was waiting for CI to finish (I don't like how azure deletes logs of interrupted runs; makes going back to previous logs much harder). In any case, I pushed your changes to #246. Like I asked above, please use that one if you want to iterate. |
Not sure if this rabbit hole ever ends... Despite doing the same for some more missing symbols now (even disambiguating further), I still run into:
|
Co-Authored-By: Isuru Fernando <isuruf@gmail.com>
…nda-forge-pinning 2023.05.17.15.05.36
Follow-up to #213 / #236, cleaned up version of #237.
Also trying to switch to shared builds on windows.
Enabling the pkg-config tests on windows needs some more work in abseil, see #242
Closes #237
Closes #246
Closes #296