Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize zlib + friends; build shared on windows [alt.] #246

Closed
wants to merge 16 commits into from

Conversation

h-vetinari
Copy link
Member

Alternative to #243.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Github got confused with having CI for the same commit run from two PRs (one cancelled), but in any case, the new run is there.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 22, 2022

Sidenote: The CI is running, GH just gets confused with the same commit having been cancelled in another PR.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 22, 2022

@isuruf, thanks for tackling the Fork bits as well, but it looks like it's not working yet (I might try bashing on it later based on what you started with).

D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(252): error C2039: 'support_enabled_': is not a member of 'grpc_core::Fork'
D:\bld\grpc-split_1666422622638\work\src/core/lib/gprpp/fork.h(38): note: see declaration of 'grpc_core::Fork'
D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(252): error C2374: 'grpc_core::support_enabled_': redefinition; multiple initialization
D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(166): note: see declaration of 'grpc_core::support_enabled_'

@h-vetinari h-vetinari deleted the private_isuru branch May 24, 2023 02:06
@h-vetinari h-vetinari mentioned this pull request Feb 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants