Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External AMReX and pyAMReX Packages #22

Closed
wants to merge 12 commits into from
Closed

External AMReX and pyAMReX Packages #22

wants to merge 12 commits into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 28, 2023

Now in Conda themselves. Migrating this will enable compatibility with other packages that depend on AMReX in Conda, e.g., WarpX and HiPACE++.

X-ref conda-forge/warpx-feedstock#74

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ax3l ax3l added the enhancement New feature or request label Oct 28, 2023
@ax3l
External AMReX and pyAMReX Packages
a75ce8f 
Now in Conda themselves. Migrating this will enable compatibility
with other packages that depend on AMReX in Conda, e.g., WarpX
and HiPACE++.
@ax3l ax3l force-pushed the topic-external-amrex-pyamrex branch from b6ec1d3 to a75ce8f Compare October 28, 2023 20:32
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Oct 28, 2023
@ax3l
Copy link
Member Author

ax3l commented Oct 28, 2023

@conda-forge-admin, please rerender

@ax3l ax3l self-assigned this Oct 28, 2023
@ax3l ax3l added the automerge Merge the PR when CI passes label Oct 28, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/impactx-feedstock/actions/runs/6679086805.

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@ax3l
Copy link
Member Author

ax3l commented Oct 29, 2023

Needs ECP-WarpX/impactx#450

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Oct 29, 2023
@ax3l ax3l mentioned this pull request Oct 29, 2023
Open
@ax3l
Copy link
Member Author

ax3l commented Oct 31, 2023

libblas and libcblas and liblapack seem to be pulled as mkl variants... and there is a missing conflict of intel-openmp on llvm-openmp/libgomp: conda-forge/intel_repack-feedstock#59

@ax3l
Windows: MKL -> OpenBLAS
ccb03ea 
`mkl` depends on `intel-openmp`, which conflicts with
`llvm-openmp`.
@ax3l
Copy link
Member Author

ax3l commented Oct 31, 2023

@conda-forge-admin, please rerender

@ax3l
Copy link
Member Author

ax3l commented Oct 31, 2023

@conda-forge-admin, please rerender

@ax3l ax3l force-pushed the topic-external-amrex-pyamrex branch from 7ae2074 to b188dce Compare October 31, 2023 22:56
@ax3l
Copy link
Member Author

ax3l commented Oct 31, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 31, 2023 22:59
@ax3l
Copy link
Member Author

ax3l commented Nov 1, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 3 commits November 1, 2023 17:46
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and co…
f2a3e2e 
…nda-forge-pinning 2023.11.01.16.01.09
@ax3l
pytest: defer to test phase
4a5e8f9 
Reduced the amount of dependencies needed in host
@ax3l
Import: If Supported Platform
39cd8ef
@ax3l
Copy link
Member Author

ax3l commented Nov 2, 2023

@conda-forge-admin, please rerender

@conda-forge conda-forge deleted a comment from github-actions bot Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/impactx-feedstock/actions/runs/6735015471.

@ax3l
Copy link
Member Author

ax3l commented Nov 10, 2023

merged into #23

@ax3l ax3l closed this Nov 10, 2023
@ax3l ax3l deleted the topic-external-amrex-pyamrex branch November 10, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTSandberg RTSandberg Awaiting requested review from RTSandberg

@RemiLehe RemiLehe Awaiting requested review from RemiLehe RemiLehe is a code owner

@cemitch99 cemitch99 Awaiting requested review from cemitch99 cemitch99 is a code owner

@n01r n01r Awaiting requested review from n01r n01r is a code owner

Assignees

@ax3l ax3l

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ax3l