Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External AMReX and pyAMReX Packages #74

Merged
merged 5 commits into from
Oct 28, 2023
Merged

External AMReX and pyAMReX Packages #74

merged 5 commits into from
Oct 28, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 26, 2023 •
edited
Loading

Now in Conda themselves. Migrating this will enable compatibility with other packages that depend on AMReX in Conda, e.g., ImpactX and HiPACE++.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ax3l ax3l added the enhancement New feature or request label Oct 26, 2023
@ax3l ax3l self-assigned this Oct 26, 2023
@ax3l ax3l requested a review from RemiLehe as a code owner October 26, 2023 08:01
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ax3l
External AMReX and pyAMReX Packages
aa6f3bb 
Now in Conda themselves. Migrating this will enable compatibility
with other packages that depend on AMReX in Conda, e.g., ImpactX
and HiPACE++.
@ax3l ax3l force-pushed the topic-external-amrex-pyamrex branch from 3fbe322 to aa6f3bb Compare October 26, 2023 08:14
@ax3l
Copy link
Member Author

ax3l commented Oct 26, 2023

@conda-forge-admin, please rerender

@ax3l
Copy link
Member Author

ax3l commented Oct 26, 2023

Couple of patches needed - should wait for 23.11:

@ax3l ax3l force-pushed the topic-external-amrex-pyamrex branch from 7940a2f to 695fb33 Compare October 27, 2023 15:57
@ax3l ax3l force-pushed the topic-external-amrex-pyamrex branch from 695fb33 to ac07924 Compare October 27, 2023 17:51
@ax3l
Copy link
Member Author

ax3l commented Oct 27, 2023

@conda-forge-admin, please rerender

@ax3l
Copy link
Member Author

ax3l commented Oct 28, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/warpx-feedstock/actions/runs/6674202875.

@ax3l ax3l closed this Oct 28, 2023
@ax3l ax3l reopened this Oct 28, 2023
@ax3l ax3l merged commit bb51932 into conda-forge:main Oct 28, 2023
32 checks passed
@ax3l ax3l deleted the topic-external-amrex-pyamrex branch October 28, 2023 18:15
ax3l
ax3l commented Oct 28, 2023
View reviewed changes
recipe/meta.yaml
- {{ pin_compatible('numpy') }}
- periodictable
- picmistandard ==0.26.0
- pyamrex {{ version }}
Copy link
Member Author

@ax3l ax3l Oct 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be >=, we have pinning on pyAMReX itself

ax3l
ax3l commented Oct 28, 2023
View reviewed changes
recipe/meta.yaml
- numpy
- openpmd-api
- pip
- pyamrex {{ version }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be >=, we have pinning on pyAMReX itself

ax3l
ax3l commented Oct 28, 2023
View reviewed changes
recipe/meta.yaml
- make # [unix]
- ninja # [win]
- pkg-config
- cmake
- libgomp # [linux]
- llvm-openmp # [osx or win]
host:
- amrex {{ version }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be >=, we have pinning on AMReX itself

@ax3l ax3l mentioned this pull request Oct 28, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe Awaiting requested review from RemiLehe RemiLehe is a code owner

Assignees

@ax3l ax3l

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ax3l