Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate export env #11

Closed
wants to merge 3 commits into from

Conversation

bollwyvl
Copy link

This adds activate/deactivate scripts for downstreams that will be expecting $LIBARCHIVE to find the .so/.dylib.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Sure, if it helps. Feel free to add yourself as a maintainer as well.

So the find_library call doesn't work? Honestly wouldn't be surprised, but figured I'd ask.

@jakirkham
Copy link
Member

Though it might be worth considering adding this to these scripts to that Python package's conda recipe instead.

@bollwyvl
Copy link
Author

Thanks for the review!

So the find_library call doesn't work? Honestly wouldn't be surprised, but figured I'd ask.

Indeed it does not... in my hacked-up staged-recipes with libarchive-c and diffoscope and this recipe as in this PR, I'm getting good builds % my screw-ups...

Though it might be worth considering adding this to these scripts to that Python package's conda recipe instead.

Hm, in trolling about, I haven't found anything other than that particular downstream which is expecting that environment. @msarahan also suggested patching that check... what is the greater sin?

Anyhow... I'll PR with that change in place. Wasn't excited about hacking this one anyway!

@bollwyvl
Copy link
Author

In some more looking, I've found a number of other libraries that do wonky things around finding libarchive for some reason, so let's close this one!

@bollwyvl bollwyvl closed this Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants