Add python-libarchive-c #3281
Add python-libarchive-c #3281
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/libarchive-c/activate.sh
Outdated
| if [ "`uname`" == 'Darwin' ] | ||
| then | ||
| # for Mac OSX | ||
| export LIBARCHIVE="${PREFIX}/lib/libarchive.dylib" |
There was a problem hiding this comment.
This has to be CONDA_PREFIX instead of PREFIX
recipes/libarchive-c/meta.yaml
Outdated
| @@ -0,0 +1,39 @@ | |||
| {% set name = "libarchive-c" %} | |||
There was a problem hiding this comment.
I'm not sure whether this is the best name. Sounds like a C library to me.
python-libarchive-c is the name of the repo, how about using that?
There was a problem hiding this comment.
The pypi upstream has conditioned me, but totally right in this case.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Made the suggested (and seconded!) changes. Tested this out locally on OSX and linux, so am hopeful re CI. Also read about reprotest on this update from the debian folks and have started looking into what it would take to adapt for use in a conda(-forge) setting... |
|
Hooray 💚! |
| - libarchive | ||
| - python | ||
| - setuptools | ||
| - toolchain |
There was a problem hiding this comment.
I don't think you need toolchain or libarchive here.
There was a problem hiding this comment.
Indeed! Thanks for the speedy review!
recipes/python-libarchive-c/build.sh
Outdated
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
| export DETERMINISTIC_BUILD=1 | |||
There was a problem hiding this comment.
Hey, gotta start somewhere.
There was a problem hiding this comment.
Absolutely nothing... as it depends on some nix-specific patches to Python. Removed.
|
It seems like a bunch of PR depend on this one. Is there anything blocking this one from being merged? |
|
Huzzah, thanks @isuruf! @synapticarbors I'll work on tidying up the others once there are builds! |
This adds https://github.com/Changaco/python-libarchive-c
As suggested over on conda-forge/libarchive-feedstock#11, this includes an activate script to help it find the
libarchivefrom there.