Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diffoscope #3282

Merged
merged 4 commits into from
Aug 3, 2017
Merged

Add diffoscope #3282

merged 4 commits into from
Aug 3, 2017

Conversation

bollwyvl
Copy link
Contributor

Adds https://diffoscope.org/

Dependent on #3281

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffoscope) and found it was in an excellent condition.

@bollwyvl bollwyvl mentioned this pull request Jul 25, 2017
@bollwyvl
Copy link
Contributor Author

Huzzah, looking good.


build:
number: 0
script: python setup.py install --single-version-externally-managed --record record.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have both a script entry and a build.sh? You could delete build.sh and do

  script: PYTHONHASHSEED=0 python setup.py install --single-version-externally-managed --record record.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Aug 3, 2017

Anything else needed here?

@msarahan msarahan merged commit a85e98c into conda-forge:master Aug 3, 2017
@msarahan
Copy link
Member

msarahan commented Aug 3, 2017

Thanks @bollwyvl and @dougalsutherland

@bollwyvl bollwyvl deleted the diffoscope-only branch August 3, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants