Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 12.0.0rc5 #116

Closed
wants to merge 40 commits into from
Closed

Update to 12.0.0rc5 #116

wants to merge 40 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Mar 30, 2021

SVML patches are currently commented out.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Ivan Butygin and others added 21 commits October 12, 2020 09:53
@isuruf
Update SVML patch to llvm11
1eee119
@isuruf
update to 11.0.0
bb72ecf
@isuruf
MNT: Re-rendered with conda-build 3.20.3, conda-smithy 3.8.1, and con…
487086b 
…da-forge-pinning 2020.10.12.09.51.03
@isuruf
Readd test
67954bb
@isuruf
upload to main
f0e6804
@isuruf
MNT: Re-rendered with conda-build 3.20.3, conda-smithy 3.8.1, and con…
1521ac8 
…da-forge-pinning 2020.10.12.15.08.21
@isuruf
update test
2792fd7
@isuruf
fix triple
8d3b515
@isuruf
make a gcc symlink for testing
3c09ce8
@isuruf
remove redundant
0d91186
@github-actions
Update to LLVM 11.0.0
e3cd375 
automerged PR by conda-forge/automerge-action
@regro-cf-autotick-bot
updated v11.0.1
5142f62
@regro-cf-autotick-bot
MNT: Re-rendered with conda-build 3.20.5, conda-smithy 3.8.6, and con…
611e4bd 
…da-forge-pinning 2021.01.04.22.18.20
@isuruf
try gcc 8
3612716
@github-actions
llvmdev v11.0.1
fabadd3 
automerged PR by conda-forge/automerge-action
@regro-cf-autotick-bot
updated v11.1.0
46ec43f
@regro-cf-autotick-bot
MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.8.6, and con…
815adf1 
…da-forge-pinning 2021.02.16.22.51.53
@h-vetinari
pin gcc==8 for ppc64le
a682e20
@h-vetinari
MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.9.0, and con…
1c0c1fd 
…da-forge-pinning 2021.02.26.15.36.03
@isuruf
Merge pull request conda-forge#115 from h-vetinari/11.1
e54bbdf 
v11.1.0
@xhochy
Add changes from master
505e84d
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Mar 31, 2021
Merged
@xhochy
Copy link
Member Author

xhochy commented Apr 1, 2021

@conda-forge/llvmdev This is ready for review/merge.

@isuruf
Copy link
Member

isuruf commented Apr 1, 2021 •
edited
Loading

Can you merge this branch with master?

@xhochy
Copy link
Member Author

xhochy commented Apr 6, 2021

Now CI is green 💚

isuruf
isuruf reviewed Apr 8, 2021
View reviewed changes
recipe/build.sh Outdated
Comment on lines 52 to 55
#make -j${CPU_COUNT} check-llvm
if [[ "$target_platform" == linux* ]]; then
ln -s $(which $CC) $BUILD_PREFIX/bin/gcc
fi

cd ../test
../build/bin/llvm-lit -vv Transforms ExecutionEngine Analysis CodeGen/X86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bring these back?

isuruf
isuruf reviewed Apr 8, 2021
View reviewed changes
recipe/build.sh Outdated Show resolved Hide resolved
@xhochy
Copy link
Member Author

xhochy commented Apr 9, 2021

@isuruf Any idea on the Linux failures?

@xhochy xhochy changed the title Update to 12.0.0rc3 Update to 12.0.0rc5 Apr 14, 2021
@xhochy
Copy link
Member Author

xhochy commented Apr 14, 2021

There is an upstream bug report for this https://bugs.llvm.org/show_bug.cgi?id=48992

@h-vetinari
Copy link
Member

llvm 12.0.0 was released; let's hope that bug gets fixed soon -> carry patch or wait for 12.0.1?

@xhochy
Copy link
Member Author

xhochy commented Apr 15, 2021

llvm 12.0.0 was released; let's hope that bug gets fixed soon -> carry patch or wait for 12.0.1?

There is currently no patch for the issue.

@h-vetinari
Copy link
Member

I understand, hence "let's hope that bug gets fixed soon". Sorry for making this hard to grok by mixing in the consequences of that yet-to-be bugfix missing 12.0.0

@h-vetinari
Copy link
Member

There is currently no patch for the issue.

Speaking of which, I saw you have an account on bugs.llvm - could you mark the issue as blocking 12.0.1 so that it hopefully doesn't miss the boat again?

@xhochy
Copy link
Member Author

xhochy commented Apr 29, 2021

@isuruf I would skip the failing tests on Linux and then would like to merge this to also update the remaining LLVM bits (MLIR, clang) to the latest RC. This would help us (i.e. myself) to prepare the recipes for when we merge the 12 release here. Would that be OK with you?

@isuruf
Copy link
Member

isuruf commented Apr 29, 2021

We can directly go to packaging 12.0.0. I don't think there's anything useful in packaging 12.0.0.rc5

@xhochy
Copy link
Member Author

xhochy commented Apr 29, 2021

I only wanted to do this as we probably don't want to merge the release until the SVML patches are updated.

@isuruf
Copy link
Member

isuruf commented Apr 29, 2021

I only wanted to do this as we probably don't want to merge the release until the SVML patches are updated.

I think that's fine. SVML patches are only needed for numba which doesn't support LLVM 12 yet (not even 11)

@xhochy xhochy mentioned this pull request May 10, 2021
Merged
3 tasks
@isuruf isuruf closed this May 11, 2021
@h-vetinari h-vetinari mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

@inducer inducer Awaiting requested review from inducer inducer is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@timsnyder timsnyder Awaiting requested review from timsnyder timsnyder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xhochy @conda-forge-linter @isuruf @h-vetinari @regro-cf-autotick-bot @xoviat