-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build 13.0.0 #131
Build 13.0.0 #131
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
9337c7a
to
f8afa39
Compare
Opened https://bugs.llvm.org/show_bug.cgi?id=51859 upstream for the linux+x86 failure and marked it as blocking for 13.0.0. |
For completeness, building on ppc fails with both gcc 8 & 9, so I'm trying 11 (skipped 10 for now): GCC 8: environment resolution error
GCC 9: linker error
GCC 11: linker error
|
Raised another issue for the PPC build problems going back to #115, which seem to affect all GCC versions >=9 when building: https://bugs.llvm.org/show_bug.cgi?id=51863 |
Upstream noted (re: PPC-vs-GCC):
I can see that we have
and best as I can tell this is originally coming from here. The GCC docs make Options I see ATM:
Any thoughts/advice @isuruf @xhochy @beckermr? EDIT: Resolution error remains with glibc 2.17
|
Unexpectedly, the build without Thoughts? |
Regarding the failure of building for PPC with GCC, upstream said:
|
With the comments happening on the upstream bug for the multiple.ll failure, I just saw noticed the following in build.sh:
I traced the addition of this back to b676b4b by @anton-malakhov. Sorry for the ping out of the blue, but since the addition isn't commented, could you maybe quickly explain what it does? |
@conda-forge/llvmdev @xhochy For the two failures I'm following the respective upstream recommendations to circumvent them, see: |
Would people prefer to carry https://reviews.llvm.org/D110589 (not landed yet) rather than removing |
From a quick look at the description, this patch is about fixing a faulty test vs disabling a feature? Then I would prefer the patch. |
Yeah, in the meantime, the discussion on the issue has progressed, and I think everyone agrees with (the approach for) the patch - though it hasn't landed yet. Will update later, thanks for taking a look! :) |
aeb6a25
to
e6fb5be
Compare
#- patches/expect-fastmath-entrypoints-in-add-TLI-mappings.ll.patch # adjusts test added in 10.0.0 for intel-D47188-svml-VF.patch effects | ||
# Revert an upstream change for Numba | ||
# ref: https://github.com/numba/llvmlite/blob/v0.29.0/conda-recipes/0001-Revert-Limit-size-of-non-GlobalValue-name.patch | ||
- patches/numba-0001-Revert-Limit-size-of-non-GlobalValue-name.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't apply anymore. There's no NonGlobalValueMaxNameSize
left in https://github.com/llvm/llvm-project/blob/release/13.x/llvm/lib/IR/Value.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in function.cpp. See llvm/llvm-project@8d25762
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the info. To be honest, I'm not sure I fully understand what's necessary for this (and think it should be done when the other numba-patches are adapted, cf. #123). Is the following the patch as you would envision it?
diff --git a/llvm/lib/IR/Function.cpp b/llvm/lib/IR/Function.cpp
index 4034b1505bd0..26600bd2d9b9 100644
--- a/llvm/lib/IR/Function.cpp
+++ b/llvm/lib/IR/Function.cpp
@@ -77,10 +77,6 @@ using ProfileCount = Function::ProfileCount;
// are not in the public header file...
template class llvm::SymbolTableListTraits<BasicBlock>;
-static cl::opt<unsigned> NonGlobalValueMaxNameSize(
- "non-global-value-max-name-size", cl::Hidden, cl::init(1024),
- cl::desc("Maximum size for the name of non-global values."));
-
//===----------------------------------------------------------------------===//
// Argument Implementation
//===----------------------------------------------------------------------===//
@@ -390,7 +386,7 @@ Function::Function(FunctionType *Ty, LinkageTypes Linkage, unsigned AddrSpace,
// We only need a symbol table for a function if the context keeps value names
if (!getContext().shouldDiscardValueNames())
- SymTab = std::make_unique<ValueSymbolTable>(NonGlobalValueMaxNameSize);
+ SymTab = std::make_unique<ValueSymbolTable>();
// If the function has arguments, mark them as lazily built.
if (Ty->getNumParams())
LLVM 13.0.0 has been released. Can someone point this PR to master, please? |
…a-forge-pinning 2021.09.14.14.16.49
Annoyingly, the windows build failed during package upload. Could you please restart it? |
Like #116
CC @xhochy @isuruf