-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump build number #16
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core, yes rerendering wipes the appveyor config and disables the windows build |
This is because of changes related to how VC versions work. The new system to use is outlined at https://conda-forge.org/docs/buildwin.html#building-for-different-vc-versions; I'll send a PR right now updating it to the current system. Yes, we know this should have been communicated better. :) If you have suggestions on how to do that feel free to weigh in: conda-forge/conda-forge.github.io#578. |
Ok, thanks, I'll try to update. |
@conda-forge-admin, please rerender |
|
||
requirements: | ||
build: | ||
- {{ compiler('cxx') }} | ||
- toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this explicitly anymore if you're using {{ compiler() }}
; it's pulled in automatically when appropriate and not used when not needed.
- vc9 # [win and py27] | ||
- vc14 # [win and py>=35] | ||
skip: true # [win and py36] | ||
number: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to bump the number for PRs that never merged; 3 is fine. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revision 3 was published as I merged accidentally :(
Oh, sorry, wasn't clear enough that I was also doing it. We could use your version instead, doesn't matter.... |
@conda-forge-admin, please rerender