Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number #16

Closed
wants to merge 2 commits into from
Closed

Bump build number #16

wants to merge 2 commits into from

Conversation

jschueller
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Contributor Author

jschueller commented May 11, 2018

@conda-forge/core, yes rerendering wipes the appveyor config and disables the windows build

@djsutherland
Copy link

djsutherland commented May 11, 2018

This is because of changes related to how VC versions work. The new system to use is outlined at https://conda-forge.org/docs/buildwin.html#building-for-different-vc-versions; I'll send a PR right now updating it to the current system.

Yes, we know this should have been communicated better. :) If you have suggestions on how to do that feel free to weigh in: conda-forge/conda-forge.github.io#578.

@jschueller
Copy link
Contributor Author

Ok, thanks, I'll try to update.

@jschueller
Copy link
Contributor Author

@conda-forge-admin, please rerender

@djsutherland djsutherland mentioned this pull request May 11, 2018
@jschueller jschueller closed this May 11, 2018
@jschueller jschueller deleted the bump2 branch May 11, 2018 13:58

requirements:
build:
- {{ compiler('cxx') }}
- toolchain

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this explicitly anymore if you're using {{ compiler() }}; it's pulled in automatically when appropriate and not used when not needed.

- vc9 # [win and py27]
- vc14 # [win and py>=35]
skip: true # [win and py36]
number: 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump the number for PRs that never merged; 3 is fine. :)

Copy link
Contributor Author

@jschueller jschueller May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revision 3 was published as I merged accidentally :(

@djsutherland
Copy link

Oh, sorry, wasn't clear enough that I was also doing it.

We could use your version instead, doesn't matter....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants