Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to cb3 format #17

Closed
wants to merge 3 commits into from
Closed

Conversation

djsutherland
Copy link

(#16)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Contributor

Is the toolchain package dropped ?

- cmake # [win]

test:
requires:
- python {{ os.environ.get('PY_VER', '') + '*' }} # [win]
- python 3.6 # [not (win and vc<14)]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because otherwise it was making a Python version matrix (which it really shouldn't be...). Not sure why that didn't happen in #16....

@djsutherland
Copy link
Author

djsutherland commented May 11, 2018

Oh, I see that build 3 did actually come out. Sure, should bump to 4 then.

And yes, you don't need to include toolchain explicitly anymore: #16 (comment)

@jschueller
Copy link
Contributor

The build fails with vc14, any idea why ?
Where have the win32 builds gone ?

@djsutherland
Copy link
Author

Win32: see conda-forge/staged-recipes#5640

vc14 dies during the link step; is there maybe a missing dependency that's getting pulled in from the system or something? Don't know...

@jschueller jschueller closed this Jul 31, 2018
@jschueller
Copy link
Contributor

it succeeds with static libs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants