Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rls 0.25.0rc0 #64

Merged
merged 6 commits into from
Jul 4, 2019
Merged

Conversation

TomAugspurger
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jorisvandenbossche
Copy link
Member

The windows ones are failing on an invalid directory name that has "py>=35" in it. So it seems you can't specify the python dependency like that.

@jorisvandenbossche
Copy link
Member

@TomAugspurger
Copy link
Contributor Author

I thought that restricting python was the preferred way, but is that only for noarch builds?

@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2019

I thought that restricting python was the preferred way, but is that only for noarch builds?

It is. Can you try python >=3.5 instead of the python >=3.5.3? Also, it may be a conda-build problem.

PS: we removed all conda-build 1.18.x series due to a bug but we are subject to the old 1.17.x series bugs and lack of modern features :-(

@TomAugspurger
Copy link
Contributor Author

Thanks Filipe, trying that.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2019

@TomAugspurger sorry. I was too quick. That is the preferred way for noarch. I totally forgot that this is not noarch.

This reverts commit e74d30d.
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jul 4, 2019 via email

@TomAugspurger TomAugspurger merged commit b501c57 into conda-forge:dev Jul 4, 2019
@TomAugspurger TomAugspurger deleted the RLS-0.25.0rc0 branch July 4, 2019 14:31
@TomAugspurger
Copy link
Contributor Author

Hmm @ocefpaf it looks like the release-candidate stuff didn't work. These packages were released into the main label: https://anaconda.org/conda-forge/pandas/files?version=0.25.0rc0

Could we delete those packages? And I'll submit another PR with fixed labels.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2019

I moved them to the rc label. Sending a PR to fix that in a moment. Hold on.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jul 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants