-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r-stringi and r-stringr R 3.5 win64 packages being pulled from defaults instead of conda-forge #6690
Comments
r-stringi
and r-stringr
R 3.5 win64 packages being pulled from defaults instead of conda-forge
@cbrueffer Two ideas on potential causes:
|
I did a little more investigation. The AnacondaRecipes recipe for r-stringi is able to skip icu completely on Windows because it is installed by their recipe of r-base: However the conda-forge recipe for r-base only installs icu on non-Windows: Thus I see two options to fix this on conda-forge:
Do we have any reasons to prefer one solution over the other? |
Thanks for the investigation @jdblischak! In principle it makes most sense to me to move the dependency to |
Any more opinions on this? Otherwise I'll create a PR to add the icu dependency for win64 to |
Option 1) from John for now and option 2) for later/next r-base update? I don't see any reason to not have iuc for Windows by default. |
Waiting on the AppVeyor builds to complete before closing this issue: https://ci.appveyor.com/project/conda-forge/r-stringi-feedstock/build/1.0.29 |
The R 3.5.1 build failed in the link above due to an HTTP timeout error. However, someone restarted a new build which passed. So I went ahead and restarted the failed recipes build (someone already restarted the failed reprex build). |
Thanks @jdblischak, I restarted the other builds but had forgotten about |
@cbrueffer Can this Issue be closed now? |
Yes, everything works fine after the fix to |
@cbrueffer For future reference, the conda-forge recipe for r-base now installs |
@jdblischak good to know, thanks! |
In several R recipes that specify
r-stringi
andr-stringr
as dependencies, in the Windows R3.5 build those packages are being pulled from defaults instead of conda-forge, leading to build errors. For R 3.4 build they are pulled from conda-forge as they should.Examples:
https://ci.appveyor.com/project/conda-forge/r-recipes-feedstock/build/1.0.7/job/8jyn8ky5eef97vlf
https://ci.appveyor.com/project/conda-forge/r-reprex-feedstock/build/1.0.2/job/ikd87p47gemnvko1
CC @bgruening @jdblischak
The text was updated successfully, but these errors were encountered: