-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's see how this goes. #61
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
Can anyone at @conda-forge/r help figure this out?
I cannot reproduce it locally using the following command line (and also saw no weird specs with conda-render):
|
recipe/meta.yaml
Outdated
# Once run_exports are in place these will not be necessary: | ||
- {{ pin_compatible('pango') }} # [not win] | ||
- {{ pin_compatible('bzip2') }} # [not win] | ||
- {{ pin_compatible('icu') }} $ [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingwandroid this is the typo. Also there is a meta.yaml.orig included in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh! How did I not spot that (and why is it not happening locally .. questions for myself)? OK. thanks.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
This is so that we can share noarch packages directly.
This reverts commit bc057ae.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
@isuruf, msys2 packages use an epoch package / mechanism to manage pinning. It's different than our usual way but works just fine! I'd rather not pin beyond that personally since then you have two mechanisms in play. |
I have some questions about this,
|
Given the two points yes. Depend on the exact epoch version here, good point. I may rebuild them later for exact pinning too. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for taking this further. |
Restarted travis which seemed to die for no good reason. |
Thanks @mingwandroid! |
Thanks all! |
Woooooo awesome! Thank you everyone for your hard work and perseverance!! |
Change to Windows r-base installation path implemented in conda-forge/r-base-feedstock#61
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)