Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinating r-base updates #46

Closed
6 tasks done
jdblischak opened this issue Jun 20, 2018 · 10 comments
Closed
6 tasks done

Coordinating r-base updates #46

jdblischak opened this issue Jun 20, 2018 · 10 comments

Comments

@jdblischak
Copy link
Member

jdblischak commented Jun 20, 2018

There are lots of changes to be made to the r-base recipe. We need to decide which changes we make simultaneously and which we do in independent stages:

For me, the highest priority are the first two items. I propose we migrate to conda-build 3 and update to R 3.5.1 together as the next big change.

Re-arranging the Windows R layout to be the same as Unix is still a work-in-progress, and would involve updating the R package recipes to properly find the license files shipped with r-base. Thus I think this change should wait until after the big update to 3.5.1.

If we want to allow users to install Microsoft R Open from the defaults channel while also having access to non-R packages from conda-forge, we need to add r-mutex 1.* anacondar_1 as a run dependency. I don't use Microsoft R Open, and don't fully understand the consequences of adding this dependency, so we'll need someone willing to take charge on this.

conda-forge has dropped support for win-32 builds, and the r-base recipes has multiple patches for win-32, so at some point we should remove these if they are no longer relevant.

To get a sense of the changes that have taken place on the defaults r-base (it's currently at 3.5.0), check out PR #45.

@dhirschfeld
Copy link
Member

I think 4. is the most crucial for compatibility with the defaults channels, assuming that means implementing the _r-mutex scheme they've adopted there. I also think 1. is very important for compatibility as well.

As a win-64 user I'm also fine with 5. and thought that policy had already been adopted.

@jdblischak
Copy link
Member Author

I think 4. is the most crucial for compatibility with the defaults channels, assuming that means implementing the _r-mutex scheme they've adopted there.

@dhirschfeld Would you like to take charge on this effort? As you can see in #34, I have regularly checked in on that issue without much success. I don't have the first idea how to manipulate tarballs on Anaconda Cloud.

As a win-64 user I'm also fine with 5. and thought that policy had already been adopted.

The policy has been adopted, but that doesn't mean it's been executed. The r-base recipe has lots of patches that appear to be win-32 specific, so at some point someone needs to investigate to see which patches we can safely remove.

@dhirschfeld
Copy link
Member

Unfortunately I doubt I'll have time this year to look at the problem. I'd love for it to Just Work and think it's a very serious problem but since I can work around/avoid it for now it's not on my critical path and I'm completely swamped with other work :/

@jdblischak
Copy link
Member Author

R 3.5.1 has been released (release notes)

@jdblischak
Copy link
Member Author

@bgruening In case it could be useful, I had created this Issue to track the various updates that have been discussed for r-base.

@jdblischak
Copy link
Member Author

jdblischak commented Sep 27, 2018

Another to-do when we get the chance: install {{native}}icu on Windows conda-forge/staged-recipes#6690

@jakirkham
Copy link
Member

FYI the compiler rebuild and R update have reached r-base. This is a good time to determine which of these need to be addressed with that PR ( #60 ).

@jakirkham
Copy link
Member

Now that PR ( #61 ) is in, would be good to update this list accordingly.

@jdblischak
Copy link
Member Author

PR #61 implemented the following updates:

Both PR #60 and #61 edited the CI configuration files, so either or both of them succeeded in dropping support for win-32 because R 3.5.1 is no longer being uploaded to Anaconda Cloud. Strangely, although some of the win32 specific patches were deleted in PR #61, there are still 3 remaining:

@jdblischak
Copy link
Member Author

I've updated the checklist above, and also followed up on Issues #34 and conda-forge/staged-recipes#6690. Since it appears that all the issues have been addressed, I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants