Rebase on top of cf #57

mingwandroid · 2018-08-05T21:23:24Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2018-08-05T21:23:29Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

mingwandroid · 2018-08-05T21:23:40Z

cc @bgruening

mingwandroid · 2018-08-05T21:31:44Z

This should be interesting, I expect failures a few times round since I've been using our compilers since 3.4.0!

bgruening · 2018-08-05T21:38:56Z

@mingwandroid; With @ocefpaf and others we are considering to use R 3.5.1 as an POC for rebuilding with the new compilers. So if this fails maybe we can include a local conda_build_config.yaml here indicating the new compilers already?

@ocefpaf @isuruf what do you think?

mingwandroid · 2018-08-05T21:40:23Z

You might need to build out the transitive c and c++ deps with them first.. shouldn't be too bad though?

isuruf · 2018-08-06T22:18:47Z

recipe/meta.yaml

+    - {{native}}bzip2 1.0.*              # [win]
+    - {{native}}libjpeg-turbo            # [win]
+    - {{native}}libiconv                 # [win]
+    - {{native}}libuuid                  # [linux]


Can you remove {{native}} here? conda-build doesn't recognize that libuuid is a used variable with {{native}} in front.

Then that is what needs to be fixed. Please consider a PR to conda-build to fix the real problem.

Why does it matter here though here since libuuid is not part of a build matrix?

isuruf · 2018-08-06T22:19:13Z

recipe/meta.yaml

+    - {{native}}gmp                      # [win]
+    - {{native}}fftw                     # [win]
+    - {{native}}xz                       # [win]
+    - {{native}}mpfr                     # [win]


This should be pinned.

No they should not, we use run_exports.

I am not going to infect my recipes with pinning.

You are wrong here anyway, msys2 packages never need pinning, they use an epoch system instead.

You are wrong here anyway, msys2 packages never need pinning, they use an epoch system instead.

Can you explain this please?

Every msys2 package depends on an epoch package and that is versioned at the date when the upstream rolling distribution packages were converted to conda packages. That is the only version constraint here because that's how rolling distributions work.

Every msys2 package depends on an epoch package and that is versioned at the date when the upstream rolling distribution packages were converted to conda packages. That is the only version constraint here because that's how rolling distributions work.

Sure. How does the r-base package pin to that epoch package? Is it done by run_exports?

Transitively each msys2 dependency depends on the same epoch version.

Future-wise, R upstream are now based on MSYS2 (and are thus more up to date than us) so we may want to consider just bundling all their static libs into a single package and using that. We'd also need to update our mingw-w64 toolchain (or provide the 'upstream' one, just for R).

bgruening · 2018-08-08T05:42:05Z

New error: configure: error: C compiler cannot create executables

bgruening · 2018-08-14T18:28:21Z

I guess this one is blocked by the epic rebuild of conda-forge.

ocefpaf · 2018-08-14T18:32:40Z

I guess this one is blocked by the epic rebuild of conda-forge.

Sadly yes :-(

jakirkham · 2018-10-13T22:21:09Z

Looks like the epic rebuild caught up to r-base. ( #60 ) Maybe time to revisit this one. 😉

mingwandroid · 2018-10-13T22:47:16Z

Caught up? Yay! conflicts, bah!

Try to get this rebased tomorrow; we need to figure something out regarding CF X11 vs AD CDT/X11 for recipes.

bgruening · 2018-10-17T20:22:12Z

Hi @mingwandroid, are you planning on working on this soon?

mingwandroid · 2018-10-18T10:36:40Z

Sorry didn't get a chance. Maybe this weekend? Do you need it earlier? I'll try to find time soon if so.

bgruening · 2018-10-18T12:17:49Z

@mingwandroid Its blocking currently the conda-forge rebuild. I can also give it a try and rebase it at least, if you like.

bgruening · 2018-10-18T12:21:02Z

@mingwandroid I tried to rebase. Feel free to revert this commit. Lets see if this gets green :)

bgruening · 2018-10-18T12:21:37Z

@conda-forge-admin, please rerender

nsoranzo · 2018-10-18T12:38:30Z

recipe/meta.yaml

-  number: 1
-  merge_build_host: True   # [win]
+  merge_build_host: True  # [win]
+  number: 0


Suggested change

number: 0

number: 2

jakirkham · 2018-10-21T01:07:35Z

...we need to figure something out regarding CF X11 vs AD CDT/X11 for recipes.

cc @pkgw

mingwandroid · 2018-10-21T11:58:42Z

@pkgw, @jakirkham, what do we want to do with things like Qt? Is it being rebuilt now on cf CI? Is it using cf X11?

r-gl from conda-forge currently links to these system (non-glibc/kernel) libraries:

ldd /opt/conda/envs/r351cf/lib/R/library/rgl/libs/rgl.so
	libglapi.so.0 => /usr/lib64/libglapi.so.0 (0x00007fe30e5dd000)
	libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fe30e3be000)
	libXdamage.so.1 => /usr/lib64/libXdamage.so.1 (0x00007fe30dfa7000)
	libXfixes.so.3 => /usr/lib64/libXfixes.so.3 (0x00007fe30dda2000)
	libXxf86vm.so.1 => /usr/lib64/libXxf86vm.so.1 (0x00007fe30d348000)
	libdrm.so.2 => /usr/lib64/libdrm.so.2 (0x00007fe30d13b000)
	libexpat.so.1 => /lib64/libexpat.so.1 (0x00007fe30caf2000)

Is this more widespread? What's the official policy as regards OpenGL/mesa? End users need to install stuff here with their system package manger. Is conda-forge using the --error-overlinking flag so that these dependencies can be explicitly identified in the recipes at least?

Rebase on top of cf

ee11f05

This was referenced Aug 5, 2018

rerender, manually increase freetype pinning conda-forge/fontconfig-feedstock#32

Closed

build r-base against 3.4.1 and 3.5.1 conda-forge/conda-forge-pinning-feedstock#107

Merged

jdblischak mentioned this pull request Aug 6, 2018

Version 3.5.1 #56

Merged

5 tasks

isuruf reviewed Aug 6, 2018

View reviewed changes

jdblischak mentioned this pull request Aug 7, 2018

Coordinating r-base updates #46

Closed

6 tasks

bgruening mentioned this pull request Aug 23, 2018

Bioconductor 3.7 recipes bioconda/bioconda-recipes#10647

Closed

bgruening mentioned this pull request Oct 18, 2018

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16 conda-forge/r-microseq-feedstock#2

Merged

Merge branch 'master' into master-3.5.1

831f374

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16

4ef6b98

nsoranzo reviewed Oct 18, 2018

View reviewed changes

recipe/meta.yaml

number: 1

merge_build_host: True # [win]

merge_build_host: True # [win]

number: 0

Copy link

nsoranzo Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

number: 0

number: 2

bgruening mentioned this pull request Oct 20, 2018

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #60

Merged

isuruf closed this Nov 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase on top of cf #57

Rebase on top of cf #57

mingwandroid commented Aug 5, 2018

conda-forge-linter commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

bgruening commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

isuruf Aug 6, 2018

mingwandroid Aug 6, 2018

isuruf Aug 6, 2018

mingwandroid Aug 6, 2018

mingwandroid Aug 6, 2018

mingwandroid Aug 6, 2018

isuruf Aug 6, 2018

mingwandroid Aug 6, 2018 •

edited

Loading

isuruf Aug 6, 2018

mingwandroid Aug 6, 2018

mingwandroid Aug 6, 2018 •

edited

Loading

bgruening commented Aug 8, 2018

bgruening commented Aug 14, 2018

ocefpaf commented Aug 14, 2018

jakirkham commented Oct 13, 2018

mingwandroid commented Oct 13, 2018

bgruening commented Oct 17, 2018

mingwandroid commented Oct 18, 2018

bgruening commented Oct 18, 2018

bgruening commented Oct 18, 2018

bgruening commented Oct 18, 2018

nsoranzo Oct 18, 2018

jakirkham commented Oct 21, 2018

mingwandroid commented Oct 21, 2018 •

edited

Loading

Rebase on top of cf #57

Rebase on top of cf #57

Conversation

mingwandroid commented Aug 5, 2018

conda-forge-linter commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

bgruening commented Aug 5, 2018

mingwandroid commented Aug 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mingwandroid Aug 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mingwandroid Aug 6, 2018 • edited Loading

Choose a reason for hiding this comment

bgruening commented Aug 8, 2018

bgruening commented Aug 14, 2018

ocefpaf commented Aug 14, 2018

jakirkham commented Oct 13, 2018

mingwandroid commented Oct 13, 2018

bgruening commented Oct 17, 2018

mingwandroid commented Oct 18, 2018

bgruening commented Oct 18, 2018

bgruening commented Oct 18, 2018

bgruening commented Oct 18, 2018

Choose a reason for hiding this comment

jakirkham commented Oct 21, 2018

mingwandroid commented Oct 21, 2018 • edited Loading

mingwandroid Aug 6, 2018 •

edited

Loading

mingwandroid Aug 6, 2018 •

edited

Loading

mingwandroid commented Oct 21, 2018 •

edited

Loading