-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.5.1 #56
Version 3.5.1 #56
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This should at least build on Linux and OSX, no clue abut Windows. |
Cool beans @dpryan79! @cbrueffer @jdblischak you might want to have a look. @ocefpaf @isuruf I guess its pretty save to merge this one. The critical part is to add 3.5.1 to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/c47376eee20cf0b80ff1c5a16e08317de9ba362e/recipe/conda_build_config.yaml#L416 right? @mingwandroid I have seen you released 3.5.0 for |
We were going to change the R layout in Windows for the new version right? |
I need to keep defaults R aligned with MRO releases, no need for conda-forge to worry about that though. |
Totally happy for cf to proceed with 3.5.1 |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
Are we? You mean to enable |
Before that you need the interpreter to have the adjusted layout, but regardless of whether you do Do you want to re-sync with my recipe here though? You'd get the Windows layout changes and also openblas is now used on linux and macOS (as it was on 3.4.3). |
That would be awesome! |
OK I'll see if I can update my r-base to 3.5.1 then we can consider a PR? |
👍 Thanks Ray! |
I'm 👍 on syncing but I'm also OK merging this as-is and work on the syncing in a new PR. |
@mingwandroid let me know if you want us to merge this one before you start working on a new one. |
Go for it, I'll not bother trying to keep my own history of changes as the rebase would be tricky so I'll just base it on top of what you have when I get finished. |
Great! Thanks @dpryan79 for pushing this forward and thanks @mingwandroid for you prompt response! |
Thanks everyone! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This PR bumps the R version to 3.5.1. I had to modify patch 0011 to get this to compile properly, so someone who know whether that patch is even still relevant should have a look. The other patches have been modified to actually apply to R 3.5.1. This additionally fixes #50 going forward, though I notice that @bgruening just added a similar test to
master
.