Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build r-base against 3.4.1 and 3.5.1 #107

Merged
merged 4 commits into from
Aug 16, 2018

Conversation

bgruening
Copy link
Contributor

@bgruening bgruening commented Aug 5, 2018

blocked by conda-forge/r-base-feedstock#56

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bgruening
Copy link
Contributor Author

@conda-forge-admin, please rerender

@@ -414,6 +414,7 @@ readline:
- 7.0
r_base:
- 3.4.1
- 3.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CJ-Wright this would be the "big migration" (besides the compilers+Python 2.7) test you are looking for 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I was just hoping to look into the future so we can plan for the migrations. I wasn't expecting someone to build a time machine and make the future now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;) you still have a few minutes, we are blocked by conda-forge/r-base-feedstock#57

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@bgruening
Copy link
Contributor Author

This is now blocked by conda-forge/r-base-feedstock#57

@ocefpaf ocefpaf merged commit ce2b512 into conda-forge:master Aug 16, 2018
@isuruf
Copy link
Member

isuruf commented Aug 16, 2018

Isn't this blocked by the r-base PR mentioned above?

@ocefpaf
Copy link
Member

ocefpaf commented Aug 17, 2018

Isn't this blocked by the r-base PR mentioned above?

I though we already had a version of 3.5.1 but I guess we need that version.

@bgruening are we close on that one? I cannot help at the moment b/c I'm in transit but I can take a look at it next week.

@bgruening bgruening deleted the r-base-351 branch August 17, 2018 11:13
@bgruening
Copy link
Contributor Author

@ocefpaf we do have r 3.5.1 but we agreed at some point to only rebuild all packages with the new compilers. But as it turns out this still takes some time. So depending on how long it might be better to start rebuilding? I'm not sure here. Currently, we have a pkg but are not using it.

@bgruening
Copy link
Contributor Author

We should probably revert this IFF we want to wait for the rebuild.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 17, 2018

We should probably revert this IFF we want to wait for the rebuild.

Let's assess if we can solve conda-forge/r-base-feedstock#57 in the next few day first. If not, then we revert this one.

@bgruening
Copy link
Contributor Author

The problem is that we need to start at least the new-compiler rebuilds :(

@CJ-Wright
Copy link
Member

I'm hoping the compiler migration will start soon. I'm happy this got in since we need as large if a sub graph as possible to make sure things are rebuilt in the correct order.

maresb pushed a commit to maresb/conda-forge-pinning-feedstock that referenced this pull request Nov 1, 2022
libarchive 3.3-3.5 are compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants