Master cf rebase #45
Closed
Master cf rebase #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an upstream recommendation: https://cran.r-project.org/doc/manuals/r-release/R-admin.html#Using-ICU-for-collation Unfortunately, this adds quite a bit to the binary size and r-stringi still links to its own ICU (again upon their recommendation).
Also adds OpenBLAS and makes the Windows layout the same as Unix so we can share packages that do not require compilation as noarch: generic
(as BUILD_PREFIX does not get considered for prefix replacement)
.. also workaround strong run_exports not being used in host and mingw-w64 toolchain being in the host section instead of the build section.
This is because R likes to add x64 to, for example, LOCAL_SOFT and this means our libs and headers do not get found. Instead, since we use MSYS2/mingw-w64 compilers and our libs are all in the sysroot we can ensure the libs and headers get found provided we do not split them into a different prefix to the prefix that contains the compilers
…blas DT_NEEDED is libRblas.so
…S support Would like to remove NLS since neither MRO nor offical R releases use it.
… libiconv + bzip2 deps We probably need to use -dead_strip_dylibs and -no_implicit_dylibs in the clang activate script, but I tested with both those and still got overlinking, so it's probably a bug in ld64. Either way I do not have time to fix this at present so instead I hack a Makefile.
This is so that the values baked into Makeconf work when users run install.packages()
Since R has an options(download.file.method) of curl (as well as libcurl)
…s *not* persist in Makeconf)
…K}_LDFLAGS wrt. compatibility
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@mingwandroid is working on a new iteration of this PR for 3.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.