-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-arrange Windows R layout to be the same as Unix #43
Conversation
This is so that we can share noarch packages directly.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
@isuruf, @johanneskoester, @ocefpaf, @sodre, @bgruening please review. |
Will the already built R packages work with this change? |
No. They need to be rebuilt but we pin the r-base dependency exactly anyway. Need to rebuild the whole set. Probably best at 3.5 release time? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Yep. Let's do this for |
cc @jdblischak |
A few quick notes:
|
R 3.5.1 will be released on July 2 |
The Windows build has been fixed (the URL to download MiKTeK was broken; see #40 and #44). @mingwandroid Would you be able to rebase your commits onto master? Note that you'll get a merge conflict because I also fixed the spacing in the Jinja2 variables defined in meta.yaml. If you'd prefer, I can perform the rebase and open a new PR (either on your branch or in the main repo). |
I would say things might be a little WIP at present (I'm adding openblas for macOS) but I rebased all my work on top of the master branch, here's a PR for discussion anyway: #45 |
Thanks @mingwandroid! I was referring to rebasing only the small number of commits in this PR, but comparing all the changes that have been made to the defaults r-base is also useful. I created a new Issue to coordinate all the updates that need to be made the conda-forge r-base feedstock. Please share your thoughts in #46. Thanks! |
R 3.5.1 has been released (release notes) |
@mingwandroid is working on a new iteration of this PR for 3.5.1 |
This is so that we can share noarch packages directly.