Add alchemiscale to conda-forge #23919
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I am willing to be a maintainer :) |
|
Thanks! 💤 |
|
I am willing to be a maintainer! Thanks @mikemhenry! |
|
@conda-forge/help-python, ready for review! |
recipes/alchemiscale/meta.yaml
Outdated
|
|
||
| build: | ||
| number: 0 | ||
| skip: true # [win] |
There was a problem hiding this comment.
B/c the outputs are noarch this will be installable on Windows regardless of this skip. What is the reason for it? If it is just a missing dependency, then it is fine to remove it and let the solver deal with it. A failure in that case is not a blocker for merging.
There was a problem hiding this comment.
Can do! I've gotten advice both ways and for noarch I also like to have the solver deal with it.
recipes/alchemiscale/meta.yaml
Outdated
| - pip check | ||
|
|
||
| about: | ||
| home: https://github.com/simplejson/simplejson |
There was a problem hiding this comment.
Oh that is embarrassing 🙈
| - numba | ||
| - pymbar >=3.0.6,<4 | ||
| - async-lru | ||
| - nest-asyncio |
There was a problem hiding this comment.
Is this package alchemiscale-compute with this extra dependency? Is so you should avoid a dual build and depend on alchemiscale-compute here instead.
There was a problem hiding this comment.
There was a problem hiding this comment.
In a perfect world, I would have some sort of alchecmiscale-base or have one depend on other other as you propose, but we are still moving very quickly on this development wise and in an iteration or two, the compute and client will be much more independent. So I figured once the dust settles on that I would re-work the dependencies.
Thank you for the suggestion!
There was a problem hiding this comment.
I'm a bit busy at the moment with some personal things to resolve. Can you request a new reviewer. Thanks!
There was a problem hiding this comment.
Yea I don't get the extra overhead right now if this is a single source with different deps 🤔 Won't it be easier to address that in the feedstock once there and make the review simpler / quicker?
|
@ocefpaf Ready for another review 😄 |
|
@conda-forge/help-python, ready for review! |
|
@conda-forge-admin, please ping team |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
|
Need a new reviewer on this PR (See #23919 (comment)) Thanks! |
recipes/alchemiscale/meta.yaml
Outdated
| - requests | ||
| - click | ||
| - httpx | ||
| - pydantic<2.0 |
There was a problem hiding this comment.
| - pydantic<2.0 | |
| - pydantic<2.0a0 |
recipes/alchemiscale/meta.yaml
Outdated
| - dask | ||
| - distributed | ||
| - numba | ||
| - pymbar >=3.0.6,<4 |
There was a problem hiding this comment.
| - pymbar >=3.0.6,<4 | |
| - pymbar >=3.0.6,<4.0a0 |
| @@ -0,0 +1 @@ | |||
| ${PYTHON} -m pip install . --no-deps -vv | |||
There was a problem hiding this comment.
I think you need some more flags here due to this bug.
|
The CI is not doing any building 🤔 Does this work locally? |
|
@jaimergp thanks for the feedback! It was working locally when I first submitted the package, I will try again to double-check. |
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
|
@jaimergp Okay ready for another pass, this is my first multi output feedstock I've submitted, so I appreciate the feedback! |
|
Oh and should I be adding |
|
@conda-forge/help-python , ready for review! |
1 similar comment
|
@conda-forge/help-python , ready for review! |
Probably not all of those but it doesn't hurt. It is a long standing bug in multiple outputs. |
|
Awesome! Thanks @ocefpaf |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).