Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alchemiscale to conda-forge #23919

Merged
merged 9 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions recipes/alchemiscale/build_package.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
${PYTHON} -m pip install . --no-deps -vv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need some more flags here due to this bug.

102 changes: 102 additions & 0 deletions recipes/alchemiscale/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
{% set name = "alchemiscale" %}
{% set version = "0.1.4" %}

package:
name: alchemiscale
version: {{ version }}

source:
url: https://github.com/openforcefield/alchemiscale/archive/refs/tags/v{{ version }}.tar.gz
sha256: d46f372adcaa257eb909587f668e791915188795b60db0c11bbfd6bfe9ac1a84

build:
number: 0
skip: true
mikemhenry marked this conversation as resolved.
Show resolved Hide resolved

outputs:
- name: alchemiscale-compute
script: build_package.sh
build:
noarch: python

requirements:
host:
- python >=3.9
- pip
run:
- python >=3.9
- gufe=0.9.1
- openfe=0.11.0
- requests
- click
- httpx
- pydantic<2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pydantic<2.0
- pydantic<2.0a0

- openmoltools
- cloudpathlib
- dask
- distributed
- numba
- pymbar >=3.0.6,<4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pymbar >=3.0.6,<4
- pymbar >=3.0.6,<4.0a0

- async-lru

test:
imports:
- alchemiscale
requires:
- pip
commands:
- pip check

- name: alchemiscale-client
script: build_package.sh
build:
noarch: python

requirements:
host:
- python >=3.9
- pip
run:
- python >=3.9
- gufe=0.9.1
- openfe=0.11.0
- requests
- click
- httpx
- pydantic<2.0
- rich
- openmoltools
- cloudpathlib
- dask
- distributed
- numba
- pymbar >=3.0.6,<4
- async-lru
- nest-asyncio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package alchemiscale-compute with this extra dependency? Is so you should avoid a dual build and depend on alchemiscale-compute here instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a perfect world, I would have some sort of alchecmiscale-base or have one depend on other other as you propose, but we are still moving very quickly on this development wise and in an iteration or two, the compute and client will be much more independent. So I figured once the dust settles on that I would re-work the dependencies.

Thank you for the suggestion!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit busy at the moment with some personal things to resolve. Can you request a new reviewer. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I don't get the extra overhead right now if this is a single source with different deps 🤔 Won't it be easier to address that in the feedstock once there and make the review simpler / quicker?



test:
imports:
- alchemiscale
requires:
- pip
commands:
- pip check

about:
home: https://github.com/openforcefield/alchemiscale
summary: 'high-throughput alchemical free energy execution system'
description: |
a high-throughput alchemical free energy execution system
for use with HPC, cloud, bare metal, and Folding@Home
license: MIT
license_family: MIT
license_file: LICENSE
doc_url: https://docs.alchemiscale.org/
dev_url: https://github.com/openforcefield/alchemiscale

extra:
recipe-maintainers:
- dotsdl
- hmacdope
- mikemhenry