-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alchemiscale to conda-forge #23919
Changes from 7 commits
aae5661
d132fdb
77cb58d
b771e10
6547f45
a7886ae
5680618
127f67c
4b700c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
${PYTHON} -m pip install . --no-deps -vv | ||
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,102 @@ | ||||||
{% set name = "alchemiscale" %} | ||||||
{% set version = "0.1.4" %} | ||||||
|
||||||
package: | ||||||
name: alchemiscale | ||||||
version: {{ version }} | ||||||
|
||||||
source: | ||||||
url: https://github.com/openforcefield/alchemiscale/archive/refs/tags/v{{ version }}.tar.gz | ||||||
sha256: d46f372adcaa257eb909587f668e791915188795b60db0c11bbfd6bfe9ac1a84 | ||||||
|
||||||
build: | ||||||
number: 0 | ||||||
skip: true | ||||||
mikemhenry marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
outputs: | ||||||
- name: alchemiscale-compute | ||||||
script: build_package.sh | ||||||
build: | ||||||
noarch: python | ||||||
|
||||||
requirements: | ||||||
host: | ||||||
- python >=3.9 | ||||||
- pip | ||||||
run: | ||||||
- python >=3.9 | ||||||
- gufe=0.9.1 | ||||||
- openfe=0.11.0 | ||||||
- requests | ||||||
- click | ||||||
- httpx | ||||||
- pydantic<2.0 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- openmoltools | ||||||
- cloudpathlib | ||||||
- dask | ||||||
- distributed | ||||||
- numba | ||||||
- pymbar >=3.0.6,<4 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- async-lru | ||||||
|
||||||
test: | ||||||
imports: | ||||||
- alchemiscale | ||||||
requires: | ||||||
- pip | ||||||
commands: | ||||||
- pip check | ||||||
|
||||||
- name: alchemiscale-client | ||||||
script: build_package.sh | ||||||
build: | ||||||
noarch: python | ||||||
|
||||||
requirements: | ||||||
host: | ||||||
- python >=3.9 | ||||||
- pip | ||||||
run: | ||||||
- python >=3.9 | ||||||
- gufe=0.9.1 | ||||||
- openfe=0.11.0 | ||||||
- requests | ||||||
- click | ||||||
- httpx | ||||||
- pydantic<2.0 | ||||||
- rich | ||||||
- openmoltools | ||||||
- cloudpathlib | ||||||
- dask | ||||||
- distributed | ||||||
- numba | ||||||
- pymbar >=3.0.6,<4 | ||||||
- async-lru | ||||||
- nest-asyncio | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this package alchemiscale-compute with this extra dependency? Is so you should avoid a dual build and depend on alchemiscale-compute here instead. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In a perfect world, I would have some sort of alchecmiscale-base or have one depend on other other as you propose, but we are still moving very quickly on this development wise and in an iteration or two, the Thank you for the suggestion! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a bit busy at the moment with some personal things to resolve. Can you request a new reviewer. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea I don't get the extra overhead right now if this is a single source with different deps 🤔 Won't it be easier to address that in the feedstock once there and make the review simpler / quicker? |
||||||
|
||||||
|
||||||
test: | ||||||
imports: | ||||||
- alchemiscale | ||||||
requires: | ||||||
- pip | ||||||
commands: | ||||||
- pip check | ||||||
|
||||||
about: | ||||||
home: https://github.com/openforcefield/alchemiscale | ||||||
summary: 'high-throughput alchemical free energy execution system' | ||||||
description: | | ||||||
a high-throughput alchemical free energy execution system | ||||||
for use with HPC, cloud, bare metal, and Folding@Home | ||||||
license: MIT | ||||||
license_family: MIT | ||||||
license_file: LICENSE | ||||||
doc_url: https://docs.alchemiscale.org/ | ||||||
dev_url: https://github.com/openforcefield/alchemiscale | ||||||
|
||||||
extra: | ||||||
recipe-maintainers: | ||||||
- dotsdl | ||||||
- hmacdope | ||||||
- mikemhenry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need some more flags here due to this bug.