Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIXD toolkit #25442

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Add AIXD toolkit #25442

merged 5 commits into from
Feb 18, 2024

Conversation

gonzalocasas
Copy link
Contributor

@gonzalocasas gonzalocasas commented Feb 17, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aixd) and found some lint.

Here's what I've got...

For recipes/aixd:

  • The following maintainers have not yet confirmed that they are willing to be listed here: amaissen. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aixd) and found some lint.

Here's what I've got...

For recipes/aixd:

  • The following maintainers have not yet confirmed that they are willing to be listed here: amaissen. Please ask them to comment on this PR if they are.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/aixd:

  • Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aixd) and found some lint.

Here's what I've got...

For recipes/aixd:

  • The following maintainers have not yet confirmed that they are willing to be listed here: amaissen. Please ask them to comment on this PR if they are.

@gonzalocasas
Copy link
Contributor Author

This package is noarch, so it seems it's ok to ignore the failing Windows build, as discussed in several other feedstocks: #15917 (review), #22249 (comment), #16707 (comment), etc

@gonzalocasas
Copy link
Contributor Author

As soon as @amaissen confirms, I believe we would be ready for review

@amaissen
Copy link

amaissen commented Feb 18, 2024

Confirm!

@gonzalocasas
Copy link
Contributor Author

@conda-forge/help-python ready for review!

@xhochy xhochy merged commit 7571c66 into conda-forge:main Feb 18, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants