-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lightning-flash #15917
Add lightning-flash #15917
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/lightning-flash:
|
Collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning! Need to use `pip install lightning-flash[image]` because conda package is not available yet (wait for conda-forge/staged-recipes#15917). Note that installing from this environment.yml or environment-linux-64.lock probably doesn't work, because lightning-flash v0.4.0 pins to pandas <1.3.0 which brings in numpy 1.19.2, but numpy >=1.20 is required to avoid the ValueError mentioned in https://stackoverflow.com/questions/66060487/valueerror-numpy-ndarray-size-changed-may-indicate-binary-incompatibility-exp (workaround is to do `pip install -U numpy` after `conda env create` to get numpy 1.21.2).
recipes/lightning-flash/meta.yaml
Outdated
|
||
extra: | ||
recipe-maintainers: | ||
- AddYourGitHubIdHere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda and @ethanwharris, are you both ok to be listed as maintainers for the lightning-flash conda recipe? I can also add others in.
- AddYourGitHubIdHere | |
- Borda | |
- ethanwharris | |
- weiji14 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, the Windows build is failing, because
|
@weiji14 maybe you can add |
I don't actually know how to add the channel tbh 🙃 The Windows failures might be acceptable though, since this is a cross-platform noarch build (see #13866 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore the failing Windows build (due to missing dependency) since this is noarch.
Crossref Lightning-Universe/lightning-flash#659.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).