Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightning-flash #15917

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Add lightning-flash #15917

merged 2 commits into from
Aug 24, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Aug 16, 2021

Crossref Lightning-Universe/lightning-flash#659.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/lightning-flash) and found some lint.

Here's what I've got...

For recipes/lightning-flash:

  • Recipe maintainer "AddYourGitHubIdHere" does not exist

weiji14 added a commit to weiji14/ctcorenet that referenced this pull request Aug 16, 2021
Collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning! Need to use `pip install lightning-flash[image]` because conda package is not available yet (wait for conda-forge/staged-recipes#15917).

Note that installing from this environment.yml or environment-linux-64.lock probably doesn't work, because lightning-flash v0.4.0 pins to pandas <1.3.0 which brings in numpy 1.19.2, but numpy >=1.20 is required to avoid the ValueError mentioned in https://stackoverflow.com/questions/66060487/valueerror-numpy-ndarray-size-changed-may-indicate-binary-incompatibility-exp (workaround is to do `pip install -U numpy` after `conda env create` to get numpy 1.21.2).

extra:
recipe-maintainers:
- AddYourGitHubIdHere
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda and @ethanwharris, are you both ok to be listed as maintainers for the lightning-flash conda recipe? I can also add others in.

Suggested change
- AddYourGitHubIdHere
- Borda
- ethanwharris
- weiji14

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lightning-flash) and found it was in an excellent condition.

@weiji14 weiji14 marked this pull request as ready for review August 24, 2021 07:28
@weiji14
Copy link
Member Author

weiji14 commented Aug 24, 2021

@conda-forge/help-python, the Windows build is failing, because pytorch does not have Windows packages on the conda-forge channel (xref conda-forge/pytorch-cpu-feedstock#32, but there are win-64 packages on the pytorch channel). Is this ok though, since the package is for a no-arch build?

Solving environment: ...working... failed

Leaving build/test directories:
  Work:
 C:\Miniconda\conda-bld\work 
  Test:
 C:\Miniconda\conda-bld\test_tmp 
Leaving build/test environments:
  Test:
source activate  C:\Miniconda\conda-bld\_test_env 
  Build:
source activate  C:\Miniconda\conda-bld\_build_env 


Traceback (most recent call last):
  File "C:\Miniconda\lib\site-packages\conda_build\environ.py", line 804, in get_install_actions
    raise DependencyNeedsBuildingError(exc, subdir=subdir)
conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform win-64: {"pytorch[version='>=1.7']"}
##[error]Cmd.exe exited with code '1'.

@Borda
Copy link
Member

Borda commented Aug 24, 2021

@weiji14 maybe you can add pytorch channel 🐰
cc: @ethanwharris

@weiji14
Copy link
Member Author

weiji14 commented Aug 24, 2021

@weiji14 maybe you can add pytorch channel rabbit

I don't actually know how to add the channel tbh 🙃 The Windows failures might be acceptable though, since this is a cross-platform noarch build (see #13866 (comment)).

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore the failing Windows build (due to missing dependency) since this is noarch.

@dopplershift dopplershift merged commit fd8fb7d into conda-forge:master Aug 24, 2021
@weiji14 weiji14 deleted the lightning-flash branch August 24, 2021 20:14
@weiji14 weiji14 mentioned this pull request Mar 12, 2023
10 tasks
@abraha2d abraha2d mentioned this pull request May 17, 2023
10 tasks
@gonzalocasas gonzalocasas mentioned this pull request Feb 18, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants