Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding icepyx package #13866

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Adding icepyx package #13866

merged 4 commits into from
Mar 12, 2021

Conversation

lsetiawan
Copy link
Member

Overview

This PR adds icepyx to conda-forge.

Pinging @JessicaS11 so that you're aware. Let me know if there are changes that need to be made in terms of dependencies.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/icepyx) and found it was in an excellent condition.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got hit with a setuptools_scm v0.0.0 version string related issue today at conda-forge/pygmt-feedstock#15, thought I'd save icepyx from some drama. See also a related PR at conda-forge/pint-feedstock#34.

recipes/icepyx/meta.yaml Outdated Show resolved Hide resolved
recipes/icepyx/meta.yaml Show resolved Hide resolved
recipes/icepyx/meta.yaml Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if icepyx v0.3.3 from PyPI works

recipes/icepyx/meta.yaml Outdated Show resolved Hide resolved
recipes/icepyx/meta.yaml Outdated Show resolved Hide resolved
@weiji14
Copy link
Member

weiji14 commented Mar 12, 2021

Hmm, that Windows build failure is interesting, probably because of this line that's setting the environment variable in a UNIX-only way?

script: SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} {{ PYTHON }} -m pip install . -vv

I thought that no-arch packages https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-python are only built on Linux, so not sure what we should do here :/

@lsetiawan
Copy link
Member Author

@conda-forge/staged-recipes This is ready for review. Thank you so much for your time!

noarch: python
script:
- export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [unix]
- set SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is noarch you don't need this. It will failed on the CIs here but there will be no Windows CI in the feedstock. It won't hurt either, but it will never be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. So we did do that but the windows CI failed. What you are saying is that would have been fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. What @weiji14 said in #13866 (comment) is correct.

There are rare cases of things that pretend to be noarch, passes on Linux, and they we find out that should've been tested on Windows. But if you ever find on of those cases the Windows users will let you know and you'll remove the noarch in the feedstock later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for that explanation 😄

@ocefpaf ocefpaf merged commit 691b74d into conda-forge:master Mar 12, 2021
@lsetiawan lsetiawan deleted the add_icepyx branch March 12, 2021 16:59
@weiji14 weiji14 mentioned this pull request Aug 24, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants