Add Allure reporting, update Python version test matrix, and prune test_api_build.py #4621

sven6002 · 2022-11-04T17:33:47Z

Description

Miscellaneous improvements:

Adds Allure reporting
Updates the Python version test matrix
Prunes tests from test_api_build.py

Resolves #4558

Checklist - did you ...

~~Add a file to the news directory (using the template) for the next release's release notes?~~
Update / Remove necessary tests?
Add / update outdated docustring?

conda-bot · 2022-11-04T17:34:03Z

We require contributors to sign our Contributor License Agreement and we don't have one on file for @sven6002.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

.github/workflows/tests.yml

tests/test_api_build.py

tests_results/assets/style.css

mbargull · 2022-11-30T18:36:56Z

tests/test-recipes/metadata/_compile-test/f2_bad.py

@@ -1 +1 @@
-I am a bad file that should not pass compileall.
+"I am a bad file that should not pass compileall"


Suggested change

"I am a bad file that should not pass compileall"

I am a bad file that should not pass compileall.

it is a .py file it will fail to recognize the file itself... it wont matter what is inside the file..

This is used for tests that compile .py to .pyc via conda_build.post.compile_missing_pyc.
f2_bad.py is intentionally a Python script with invalid syntax.
We test that compile_missing_pyc does not produce the corresponding .pyc for it but also does not fail the build.

Ah I see, the test is effectively doing:

python -Wi -m py_compile f1.py f2_bad.py f3.py

Unfortunately, Python 3.10 reworked py_compile so it stops compiling after encountering the first error. We can silence the error with the new --quiet argument but that doesn't result in the remaining files being compiled.

So it doesn't look like this test is possible anymore without batching the compiling in which case the test feels moot?

dholth

no \ on macosx

.github/workflows/tests.yml

docs/requirements.txt

setup.py

tests/test-recipes/metadata/_compile-test/f2_bad.py

tests/test_api_build.py

docs/requirements.txt

.github/workflows/tests.yml

conda_build/conda_interface.py

tests/test_api_build.py

Python 3.10 and numpy 1.16 are not compatible so to move forward with supporting Python 3.10 and soon 3.11 we will need to also bump up the default numpy variant.

These tests utilized a bad glob pattern that assumes only 2 digit Python version (e.g., py37, py38, py39) but fails for valid 3 digit versions (e.g., py310, py311).

kenodegard · 2022-12-14T07:04:32Z

conda_build/variants.py

-    'python': f'{sys.version_info.major}.{sys.version_info.minor}',
-    'numpy': '1.16',
+    "python": f"{sys.version_info.major}.{sys.version_info.minor}",
+    "numpy": "1.21",


The default numpy variant (1.16) is not compatible with Python 3.10, i.e., the following fails:

$ conda create -n scratch python=3.10 numpy=1.16

so we bump the minimum variant up to 1.21 (the minimum numpy variant was last bumped up in Jan 2021 from 1.11 to 1.16 in ff35940):

$ conda search 'numpy * py310*' Loading channels: done # Name Version Build Channel numpy 1.21.2 py310h2cbf25c_0 pkgs/main numpy 1.21.2 py310h7b614ad_0 pkgs/main numpy 1.21.5 py310h1ad2b02_1 pkgs/main numpy 1.21.5 py310h1ad2b02_2 pkgs/main numpy 1.21.5 py310h6c44a92_3 pkgs/main numpy 1.21.5 py310hdcd3fac_1 pkgs/main numpy 1.21.5 py310hdcd3fac_2 pkgs/main numpy 1.21.5 py310hdcd3fac_3 pkgs/main numpy 1.22.3 py310h1ad2b02_0 pkgs/main numpy 1.22.3 py310hdcd3fac_0 pkgs/main numpy 1.23.1 py310h6c44a92_0 pkgs/main numpy 1.23.1 py310hdcd3fac_0 pkgs/main numpy 1.23.3 py310h6c44a92_0 pkgs/main numpy 1.23.3 py310h6c44a92_1 pkgs/main numpy 1.23.3 py310hc1140d4_0 pkgs/main numpy 1.23.3 py310hc1140d4_1 pkgs/main numpy 1.23.4 py310h9638375_0 pkgs/main numpy 1.23.4 py310he50c29a_0 pkgs/main

kenodegard · 2022-12-14T07:04:35Z

tests/test-recipes/metadata/numpy_build_run/run_test.bat

 conda list -p "%PREFIX%" --canonical
 if errorlevel 1 exit 1
-conda list -p "%PREFIX%" --canonical | grep "conda-build-test-numpy-build-run-1\.0-py..h......._0"


This glob pattern is problematic once we start testing with Python 3.10. Notice the py..h pattern near the end, this will successfully match py38 and py39 but not py310 or py311. Replaced this explicit pattern with a more fuzzy py.* pattern.

this is not within the scope of this PR.. I'll make the change for it in the next ticket..

this was required to get tests to pass (and has already been implemented in this PR, see fac2add)

this is a side effect of changing the Python versions being tested

dholth · 2022-12-14T12:28:07Z

@kenodegard thanks for making the tests pass. Let's figure out how to merge this PR and do any improvements in a new short-lived PR.

tests/test-recipes/metadata/_overlinking_detection/bld.bat

sven6002 · 2022-12-14T18:52:42Z

Dooone

travishathaway linked an issue Nov 17, 2022 that may be closed by this pull request

Prune test_api_build.py relevant test #4558

Closed

3 tasks

sven6002 marked this pull request as ready for review November 23, 2022 15:26

sven6002 requested review from kenodegard, jezdez, beeankha, dbast, LtDan33 and travishathaway November 23, 2022 15:28

kenodegard mentioned this pull request Nov 23, 2022

Cleanup replay variables & use setup-miniconda #4648

Merged

3 tasks

dholth reviewed Nov 29, 2022

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

dholth reviewed Nov 29, 2022

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

dholth reviewed Nov 29, 2022

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

dholth reviewed Nov 29, 2022

View reviewed changes

tests/test_api_build.py Outdated Show resolved Hide resolved

tests_results/assets/style.css Outdated Show resolved Hide resolved

mbargull reviewed Nov 30, 2022

View reviewed changes

dholth requested changes Dec 1, 2022

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

dholth requested changes Dec 2, 2022

View reviewed changes

dholth reviewed Dec 2, 2022

View reviewed changes

tests/test_api_build.py Outdated Show resolved Hide resolved

tests/test_api_build.py Outdated Show resolved Hide resolved

tests/test_api_build.py Outdated Show resolved Hide resolved

docs/requirements.txt Outdated Show resolved Hide resolved

sven6002 added 5 commits December 7, 2022 10:42

Trying to Create a Results Folder...

f695dca

adding new libraries...

2a1c6e3

Running on GH CI...

79c6de1

Restting Testing execution file

4ae47e3

backlash correction..

bc321ef

beeankha added the source::anaconda created by members of Anaconda, Inc. label Dec 7, 2022

sven6002 added 6 commits December 8, 2022 10:01

Removing Spaces

057078e

Adding a link in the summary report...

3c96300

uploading pytest results artifacts

7c0527e

Adding changes to test_api_build.py...

e34a85e

the .pyc addition to utils.py

72c7fe6

changing the format..

3fd8d16

dholth added 3 commits December 13, 2022 17:32

remove obsolete skipif from test_api_build

f657c7f

add blank line

f9eb90f

call api.build() in test_recipe_builds

ea18d4c

dholth reviewed Dec 13, 2022

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

conda_build/conda_interface.py Show resolved Hide resolved

tests/test_api_build.py Outdated Show resolved Hide resolved

dholth and others added 5 commits December 13, 2022 17:51

flake8 changes

9b0001e

Revert CONDA_TEST_VAR_3 back to CONDA_TEST_VAR_2

4b31c26

Test lower and upper Python versions

db6ea98

Bump default numpy to 1.21

1880151

Python 3.10 and numpy 1.16 are not compatible so to move forward with supporting Python 3.10 and soon 3.11 we will need to also bump up the default numpy variant.

Modernize tests

fac2add

These tests utilized a bad glob pattern that assumes only 2 digit Python version (e.g., py37, py38, py39) but fails for valid 3 digit versions (e.g., py310, py311).

kenodegard reviewed Dec 14, 2022

View reviewed changes

kenodegard added 3 commits December 14, 2022 01:56

Bump sympy to 1.10 to support Python 3.10

63dfe5e

Skip bad compile test for Python 3.10

aa0a31b

Fix lib/pythonM.M regex pattern to support Python 3.10

df41ef4

kenodegard force-pushed the conda-build-4558 branch from 1d33952 to df41ef4 Compare December 14, 2022 08:14

kenodegard reviewed Dec 14, 2022

View reviewed changes

tests/test-recipes/metadata/_overlinking_detection/bld.bat Outdated Show resolved Hide resolved

Removing new files?

4859edc

kenodegard approved these changes Dec 14, 2022

View reviewed changes

kenodegard changed the title ~~Conda build 4558~~ Add Allure reporting and update Python version test matrix Dec 14, 2022

dholth approved these changes Dec 14, 2022

View reviewed changes

kenodegard changed the title ~~Add Allure reporting and update Python version test matrix~~ Add Allure reporting, update Python version test matrix, and prune test_api_build.py Dec 14, 2022

beeankha approved these changes Dec 14, 2022

View reviewed changes

kenodegard merged commit daeda52 into main Dec 14, 2022

kenodegard deleted the conda-build-4558 branch December 14, 2022 18:51

This was referenced Dec 16, 2022

Move tar-ing into separate step to avoid shadowing test results #4679

Merged

Re-Evaluating test.yml file to remove old installations #4646

Closed

github-actions bot added the locked [bot] locked due to inactivity label Dec 15, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Allure reporting, update Python version test matrix, and prune test_api_build.py #4621

Add Allure reporting, update Python version test matrix, and prune test_api_build.py #4621

sven6002 commented Nov 4, 2022 •

edited by kenodegard

Loading

conda-bot commented Nov 4, 2022

mbargull Nov 30, 2022

sven6002 Nov 30, 2022

mbargull Nov 30, 2022

kenodegard Dec 14, 2022

dholth left a comment

kenodegard Dec 14, 2022

kenodegard Dec 14, 2022

sven6002 Dec 14, 2022

kenodegard Dec 14, 2022 •

edited

Loading

kenodegard Dec 14, 2022

dholth commented Dec 14, 2022 •

edited

Loading

sven6002 commented Dec 14, 2022

		@@ -1 +1 @@
		I am a bad file that should not pass compileall.
		"I am a bad file that should not pass compileall"

Add Allure reporting, update Python version test matrix, and prune test_api_build.py #4621

Add Allure reporting, update Python version test matrix, and prune test_api_build.py #4621

Conversation

sven6002 commented Nov 4, 2022 • edited by kenodegard Loading

Description

Checklist - did you ...

conda-bot commented Nov 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dholth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenodegard Dec 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dholth commented Dec 14, 2022 • edited Loading

sven6002 commented Dec 14, 2022

sven6002 commented Nov 4, 2022 •

edited by kenodegard

Loading

kenodegard Dec 14, 2022 •

edited

Loading

dholth commented Dec 14, 2022 •

edited

Loading