Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_pypi_skeleton.py to use parametrize and convert OrderedDict to dict #4731

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Tests were previously written without using parameterize. Was also still using OrderedDict when dict is sufficient.

Xref: #4590

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the source::anaconda created by members of Anaconda, Inc. label Jan 19, 2023
@kenodegard kenodegard requested a review from sven6002 January 19, 2023 00:47
@kenodegard kenodegard self-assigned this Jan 19, 2023
@kenodegard kenodegard mentioned this pull request Jan 19, 2023
46 tasks
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 19, 2023
@kenodegard kenodegard changed the title Refactor test_pypi_skeleton.py to use parametrize and convert OrderedDict for dict Refactor test_pypi_skeleton.py to use parametrize and convert OrderedDict to dict Jan 19, 2023
@kenodegard kenodegard merged commit 5a3dec4 into conda:main Jan 19, 2023
@kenodegard kenodegard deleted the test_pypi_skeleton branch January 19, 2023 18:09
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants