Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_pypi_skeleton.py to use parametrize and convert OrderedDict to dict #4731

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Refactor test_pypi_skeleton.py to use parametrize and convert OrderedDict to dict #4731

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf9936a
Refactored tests into parametrized tests
kenodegard Jan 19, 2023
660e7f6
Switch from OrderedDict to dict
kenodegard Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 69 additions & 73 deletions tests/test_pypi_skeleton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,92 +1,88 @@
# Copyright (C) 2014 Anaconda, Inc
# SPDX-License-Identifier: BSD-3-Clause
from collections import OrderedDict
import pytest

from conda.auxlib.ish import dals
from conda_build.skeletons import pypi
from conda_build.skeletons.pypi import _print_dict, _formating_value


def test_version_compare():
short_version = '2.2'
long_version = '1.4.5'
post_version = '2.2.post3'
pre_version = '2.2.pre3'
alpha_version = '1.4.5a4'
beta_version = '1.4.5b4'
rc_version = '1.4.5rc4'
padding_version_short = '2.2.0'
padding_version_long = '1.4.5.0'
@pytest.mark.parametrize(
"version,version_range",
[
("2.2", " >=2.2,<3"),
("1.4.5", " >=1.4.5,<1.5"),
("2.2.post3", " >=2.2.post3,<3"),
("2.2.pre3", " >=2.2.pre3,<3"),
("1.4.5a4", " >=1.4.5a4,<1.5"),
("1.4.5b4", " >=1.4.5b4,<1.5"),
("1.4.5rc4", " >=1.4.5rc4,<1.5"),
("2.2.0", " >=2.2.0,<2.3"),
("1.4.5.0", " >=1.4.5.0,<1.4.6"),
],
)
def test_version_compare(version, version_range):
assert pypi.convert_version(version) == version_range

assert pypi.convert_version(short_version) == ' >=2.2,<3'
assert pypi.convert_version(long_version) == ' >=1.4.5,<1.5'
assert pypi.convert_version(post_version) == ' >=2.2.post3,<3'
assert pypi.convert_version(pre_version) == ' >=2.2.pre3,<3'
assert pypi.convert_version(alpha_version) == ' >=1.4.5a4,<1.5'
assert pypi.convert_version(beta_version) == ' >=1.4.5b4,<1.5'
assert pypi.convert_version(rc_version) == ' >=1.4.5rc4,<1.5'
assert pypi.convert_version(padding_version_short) == ' >=2.2.0,<2.3'
assert pypi.convert_version(padding_version_long) == ' >=1.4.5.0,<1.4.6'


def test_formating_value():
assert _formating_value("summary", "SUMMARY SUMMARY") == " \"SUMMARY SUMMARY\"\n"
assert _formating_value("description", "DESCRIPTION DESCRIPTION") == " \"DESCRIPTION DESCRIPTION\"\n"
assert _formating_value("script", "SCRIPT VALUE") == " \"SCRIPT VALUE\"\n"
assert _formating_value("name", "{{name|lower}}") == " \"{{name|lower}}\"\n"
assert _formating_value("name", "NORMAL NAME") == " NORMAL NAME\n"
@pytest.mark.parametrize(
"name,value,result",
[
("summary", "SUMMARY SUMMARY", ' "SUMMARY SUMMARY"\n'),
("description", "DESCRIPTION DESCRIPTION", ' "DESCRIPTION DESCRIPTION"\n'),
("script", "SCRIPT VALUE", ' "SCRIPT VALUE"\n'),
("name", "{{name|lower}}", ' "{{name|lower}}"\n'),
("name", "NORMAL NAME", " NORMAL NAME\n"),
],
)
def test_formating_value(name, value, result):
assert _formating_value(name, value) == result


def test_print_dict():
recipe_metadata = {
"about": OrderedDict(
[
("home", "https://conda.io"),
("license", "MIT"),
("license_family", "MIT"),
("summary", "SUMMARY SUMMARY SUMMARY"),
("description", "DESCRIPTION DESCRIPTION DESCRIPTION"),
]
),
"source": OrderedDict(
[
("sha256", "4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732"),
("url", "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"),
]
),
"package": OrderedDict(
[("name", "{{ name|lower }}"), ("version", "{{ version }}")]
),
"build": OrderedDict(
[
("number", 0),
("script", "{{ PYTHON }} -m pip install . -vv"),
]
),
"about": {
"home": "https://conda.io",
"license": "MIT",
"license_family": "MIT",
"summary": "SUMMARY SUMMARY SUMMARY",
"description": "DESCRIPTION DESCRIPTION DESCRIPTION",
},
"source": {
"sha256": "4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732",
"url": "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz",
},
"package": {
"name": "{{ name|lower }}",
"version": "{{ version }}",
},
"build": {
"number": 0,
"script": "{{ PYTHON }} -m pip install . -vv",
},
}
recipe_order = ["package", "source", "build", "about"]
recipe_yaml = dals(
"""
package:
name: "{{ name|lower }}"
version: "{{ version }}"

assert (
_print_dict(
recipe_metadata,
order=["package", "source", "build", "about"],
)
== """package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
sha256: 4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"
source:
sha256: 4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"

build:
number: 0
script: "{{ PYTHON }} -m pip install . -vv"
build:
number: 0
script: "{{ PYTHON }} -m pip install . -vv"

about:
home: "https://conda.io"
license: MIT
license_family: MIT
summary: "SUMMARY SUMMARY SUMMARY"
description: "DESCRIPTION DESCRIPTION DESCRIPTION"
about:
home: "https://conda.io"
license: MIT
license_family: MIT
summary: "SUMMARY SUMMARY SUMMARY"
description: "DESCRIPTION DESCRIPTION DESCRIPTION"

"""
""" # yes, the trailing extra newline is necessary
)
assert _print_dict(recipe_metadata, order=recipe_order) == recipe_yaml