Fix duplicate channels added by channel pins #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
jaimergp
reviewed
Mar 13, 2024
tl-hbk
force-pushed
the
tl-hbk/fix_dupe_channels
branch
from
69d4a6b to
7a4ad41
Compare
|
CI is broken (I need to fix a couple things after some changes upstream), but this looks sensible to me. Thanks! |
jezdez
force-pushed
the
tl-hbk/fix_dupe_channels
branch
from
7a4ad41 to
7b225cb
Compare
jaimergp
approved these changes
Mar 19, 2024
|
Thanks @tl-hbk! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging #447 I noticed that channel pins would add duplicate channels.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?