Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda-build compatibility regression #531

Merged
merged 18 commits into from
Sep 24, 2024
Merged

Fix conda-build compatibility regression #531

merged 18 commits into from
Sep 24, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Sep 23, 2024

Description

#449 introduced a regression (identified in conda-forge/rust-feedstock#210) caused by two different bugs in conda.model.channel.Channel: conda/conda#14259 and conda/conda#14258.

It's a kind of a perfect storm situation:

  • Requires multi-output recipe with first output being noarch and second output being OS-specific
  • Deduplication is based on __eq__ which in Channel deliberately ignores the subdir.
  • We were passing subdirs explicitly but this is silently ignored in Channel.urls() if Channel.platform is defined.

The fix is to remove Channel.platform attributes to let the explicit subdirs take over and then we can deduplicate safely.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 23, 2024
@jaimergp jaimergp requested a review from jezdez September 24, 2024 14:53
@jaimergp jaimergp added this to the 24.9 milestone Sep 24, 2024
@jezdez jezdez merged commit 590010c into main Sep 24, 2024
63 checks passed
@jezdez jezdez deleted the investigate-rust-210 branch September 24, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants