Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the snapshot configuration field #28

Merged
merged 16 commits into from
Aug 17, 2023
Merged

Add the snapshot configuration field #28

merged 16 commits into from
Aug 17, 2023

Conversation

voscob
Copy link
Contributor

@voscob voscob commented Dec 1, 2022 •
edited
Loading

Description

In this pull request, a new configuration boolean field snapshot has been added, determining whether the connector will take a snapshot of the entire table before starting CDC mode. The default value is true.

UPD: I've removed a colomns source configuration parameter.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@voscob voscob requested review from maksenius and oykmnk December 1, 2022 13:41
maksenius
maksenius reviewed Dec 1, 2022
View reviewed changes
source/source.go Outdated Show resolved Hide resolved
@voscob
Return records with the different mode as records with the different …
8aa57c3 
…operation (#29)

* Return records with the different mode as records with the different operation

* Add unit tests for iterator's position
hariso
hariso reviewed Jan 6, 2023
View reviewed changes
README.md Show resolved Hide resolved
destination/destination.go Show resolved Hide resolved
source/iterator/iterator.go Show resolved Hide resolved
source/iterator/position_test.go Show resolved Hide resolved
source/source_integration_test.go Show resolved Hide resolved
source/source_integration_test.go Show resolved Hide resolved
destination/destination_integration_test.go Show resolved Hide resolved
@voscob voscob requested a review from a team as a code owner January 21, 2023 13:25
@maha-hajja maha-hajja self-assigned this Aug 15, 2023
maha-hajja
maha-hajja approved these changes Aug 17, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@maha-hajja maha-hajja merged commit 1263150 into main Aug 17, 2023
@maha-hajja maha-hajja deleted the snapshot-mode branch August 17, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksenius maksenius maksenius left review comments

@hariso hariso hariso left review comments

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees

@maha-hajja maha-hajja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voscob @hariso @maksenius @maha-hajja