Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration parameter #36

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Remove configuration parameter #36

merged 1 commit into from
Dec 20, 2022

Conversation

voscob
Copy link
Contributor

@voscob voscob commented Dec 20, 2022

Description

I've removed a colomns source configuration parameter.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@voscob voscob requested a review from maksenius December 20, 2022 17:36
@voscob voscob requested a review from a team as a code owner December 20, 2022 17:36
@voscob voscob merged commit 4e357e6 into snapshot-mode Dec 20, 2022
@voscob voscob deleted the source-remove-columns-param branch December 20, 2022 19:33
maha-hajja added a commit that referenced this pull request Aug 17, 2023
@voscob @hariso @maha-hajja
Add the snapshot configuration field (#28)
1263150 
* Add the snapshot configuration field

* Return records with the different mode as records with the different operation (#29)

* Return records with the different mode as records with the different operation

* Add unit tests for iterator's position

* Delete unnecessary integration tests, refactoring (#30)

* Delete unnecessary integration tests

* Update comments of methods

* Update codeowners file

* Update CODEOWNERS (#31)

* Remove  configuration parameter (#36)

* Fix: copyright year doesn't have to be the current year

* review + refactor

* fixes

* upgrade conduit sdk and protocol

* go mod updates

---------

Co-authored-by: Haris Osmanagić <haris.osmanagic@gmail.com>
Co-authored-by: maha-hajja <maha.d.hajja@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksenius maksenius maksenius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voscob @maksenius