fix GPAW mask in the reset vector #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingelish
force-pushed
the
fix-gpaw-mask
branch
2 times, most recently
from
584d76f
to
46355f2
Compare
|
@dingelish, could you please give your signed-off-by tag? |
GPAW is the [0:6] bit of ESP. the current mask 0x2f does not extract the 5th bit. 0x3f is the correct bitmask. this should close issue confidential-containers#734 Signed-off-by: Yu Ding <dingelish@gmail.com>
dingelish
force-pushed
the
fix-gpaw-mask
branch
from
46355f2
to
0877d44
Compare
|
Thanks for the reminder. I just added the signed-off-by tag to the commit message. Is it ok? |
jyao1
approved these changes
Sep 10, 2024
|
This is no longer needed after #738. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPAW is the [0:6] bit of ESP. the current mask 0x2f does not extract the 5th bit. 0x3f is the correct bitmask.
this should close issue #734