ResetVector: remove 5-level paging #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Sep 12, 2024
| "Ipl": "0x349000", | ||
| "ResetVector": "0x008000" | ||
| "Ipl": "0x34A000", | ||
| "ResetVector": "0x007000" |
|
Need check CR4.LA57. |
5-level paging is not necessary in td-shim, remove the related code and page table entry in reset vector. td-shim checks the CR4.LA57 before setting the new page table, it will panic if the bit is set. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
gaojiaqi7
force-pushed
the
0911/remove_5_level_pt
branch
from
5109752
to
198a3d2
Compare
jyao1
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5-level paging is not necessary in td-shim, remove the related code and page table entry in reset vector.
As the level 5 entry is removed, update the size of
ResetVectorin image layout.This PR should close #734 as GPAW is no longer needed.