Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #403 by adding
fetch
as an option toGrpcWebTransportOptions
so that users of SvelteKit gain various benefits from providing a fetch instance (docs).My prettier config mangled the formatting. Is there anyway you could please share your prettier config so that I can align it?
edit:
This was the easiest path forward. Arguably, it would be slightly better performance wise to add fetch as an optional parameter to the returned functions. However, doing so would require a bit more changes, including the generators.
I'm willing to make those changes if that's the path you'd prefer.