Allow a fetch override for connect-web #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was unclear to me whether it was necessary to pull in `createFetchClient`, but this seems to do the trick in the most obvious possible way.
This reverts commit 5643542.
bufdev
changed the title
timostamm
reviewed
May 5, 2023
There was a problem hiding this comment.
This PR allows for passing in a custom fetch implementation, such as that used by sveltekit (and Angular zones, so I have it).
Sweet!
To really test this, you need to actually use it with one of these libraries, so I have done so as a proof of concept in bufbuild/connect-es-integration@6ddf8e3.
It looks like we are providing the Svelte fetch function to a client that makes both a unary and a server-streaming call, with the Connect protocol with the JSON format. Do both calls happen server side with this call, and no RPC request happens after page load?
Does this work with gRPC-web as well?
timostamm
reviewed
May 8, 2023
timostamm
approved these changes
May 9, 2023
paul-sachs
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #403
This PR allows for passing in a custom fetch implementation, such as that used by sveltekit (and Angular zones, so I have it).
To really test this, you need to actually use it with one of these libraries, so I have done so as a proof of concept in connectrpc/examples-es@6ddf8e3.