Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop supporting Node.js earlier than v16 in protoc-gen-es #614

Merged
merged 8 commits into from
May 4, 2023
Merged

Stop supporting Node.js earlier than v16 in protoc-gen-es #614

merged 8 commits into from
May 4, 2023

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented May 3, 2023 •
edited
Loading

I noticed that protoc-gen-connect-es is using node 14, which is now completely EOL. Especially with the pending 1.0 release for some things, it's a good time to get on node 18, the present "active LTS".

closes TCN-1694

@dimitropoulos dimitropoulos changed the title updates package.json engines field for active node LTS Update package.json engines field for active node LTS May 3, 2023
@dimitropoulos dimitropoulos requested review from timostamm and smaye81 May 3, 2023 15:13
timostamm
timostamm requested changes May 3, 2023
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this up to date. Node v14 is no longer maintained, good call to remove it. Node v16 on the other hand is maintained and we support it.

package.json Outdated Show resolved Hide resolved
dimitropoulos
dimitropoulos commented May 3, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@dimitropoulos
Copy link
Contributor Author

@timostamm a4dfe8d (#614) goes with node 16

@dimitropoulos dimitropoulos requested a review from timostamm May 3, 2023 18:15
timostamm
timostamm approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update PR title before merging.

@dimitropoulos dimitropoulos changed the title Update package.json engines field for active node LTS Update package.json engines field for node 16 May 4, 2023
@dimitropoulos dimitropoulos merged commit b7d0f51 into main May 4, 2023
@dimitropoulos dimitropoulos deleted the dimitri/engines-update branch May 4, 2023 17:54
@timostamm timostamm changed the title Update package.json engines field for node 16 Stop supporting Node.js earlier than v16 in protoc-gen-es May 17, 2023
@timostamm timostamm mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

@smaye81 smaye81 Awaiting requested review from smaye81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitropoulos @timostamm