Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting Node.js earlier than v16 in protoc-gen-es #614

Merged
merged 8 commits into from
May 4, 2023
Merged

Stop supporting Node.js earlier than v16 in protoc-gen-es #614

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa082eb
updates package.json engines field for active node LTS
dimitropoulos May 3, 2023
2545e62
adds package.json engines field to those packages missing it
dimitropoulos May 3, 2023
a4dfe8d
changes node version to 16
dimitropoulos May 3, 2023
ba838b2
Revert "changes node version to 16"
dimitropoulos May 3, 2023
657202a
Revert "adds package.json engines field to those packages missing it"
dimitropoulos May 3, 2023
41eccd6
Revert "updates package.json engines field for active node LTS"
dimitropoulos May 3, 2023
2f99e92
update node 14 deps to node 16
dimitropoulos May 4, 2023
114026e
Merge remote-tracking branch 'origin/main' into dimitri/engines-update
dimitropoulos May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"type": "module",
"engineStrict": true,
dimitropoulos marked this conversation as resolved.
Show resolved Hide resolved
"engines": {
"node": ">=16",
"npm": ">=8"
"node": ">=18",
"npm": ">=9"
dimitropoulos marked this conversation as resolved.
Show resolved Hide resolved
},
"devDependencies": {
"typescript": "^5.0.3",
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"require": "./dist/cjs/index.js"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18",
"npm": ">=9"
},
"dependencies": {
"@bufbuild/connect": "0.8.6",
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-fastify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"require": "./dist/cjs/index.js"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18",
"npm": ">=9"
},
"dependencies": {
"@bufbuild/connect": "0.8.6",
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"require": "./dist/cjs/index.js"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18",
"npm": ">=9"
},
"dependencies": {
"@bufbuild/connect": "0.8.6",
Expand Down
4 changes: 4 additions & 0 deletions packages/connect-node-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"name": "@bufbuild/connect-node-test",
"private": true,
"engines": {
"node": ">=18",
"npm": ">=9"
},
"scripts": {
"clean": "rm -rf ./dist/esm/*",
"generate": "buf generate",
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"require": "./dist/cjs/index.js"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18",
"npm": ">=9"
},
"dependencies": {
"@bufbuild/connect": "0.8.6",
Expand Down
4 changes: 4 additions & 0 deletions packages/connect-web-bench/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"name": "@bufbuild/connect-web-bench",
"private": true,
"engines": {
"node": ">=18",
"npm": ">=9"
},
"scripts": {
"generate": "buf generate",
"report": "node report.mjs > README.md",
Expand Down
4 changes: 4 additions & 0 deletions packages/connect-web-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"name": "@bufbuild/connect-web-test",
"private": true,
"engines": {
"node": ">=18",
"npm": ">=9"
},
"scripts": {
"clean": "rm -rf ./dist/esm/*",
"generate": "buf generate",
Expand Down
4 changes: 4 additions & 0 deletions packages/connect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"version": "0.8.6",
"description": "Type-safe APIs with Protobuf and TypeScript.",
"license": "Apache-2.0",
"engines": {
"node": ">=18",
"npm": ">=9"
},
"repository": {
"type": "git",
"url": "https://github.com/bufbuild/connect-es.git",
Expand Down
3 changes: 2 additions & 1 deletion packages/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"generate": "buf generate"
},
"engines": {
"node": ">=16"
"node": ">=18",
"npm": ">=9"
},
"dependencies": {
"@bufbuild/connect-node": "^0.8.6",
Expand Down
3 changes: 2 additions & 1 deletion packages/protoc-gen-connect-es/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"protoc-gen-connect-es": "bin/protoc-gen-connect-es"
},
"engines": {
"node": ">=14"
"node": ">=18",
"npm": ">=9"
},
"scripts": {
"clean": "rm -rf ./dist/cjs/*",
Expand Down
3 changes: 2 additions & 1 deletion packages/protoc-gen-connect-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"protoc-gen-connect-web": "bin/protoc-gen-connect-web"
},
"engines": {
"node": ">=14"
"node": ">=18",
"npm": ">=9"
},
"scripts": {
"clean": "rm -rf ./dist/cjs/*",
Expand Down