Update the WritableIterable behavior
#724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikrsna-buf
commented
Jul 20, 2023
Comment on lines
+269
to
+274
| .then((result) => | ||
| expect(result).toEqual({ done: true, value: undefined }) | ||
| ) | ||
| .catch(() => | ||
| fail("expected successful done result but unexpectedly rejected") | ||
| ); |
There was a problem hiding this comment.
Changed the behavior for next to return {done: true} when the writer is closed either due to an error or with call toclose. This is what I think should be the behavior of Iterables outlined here, based on these two paragraphs:
If an iterator returns a result with done: true, any subsequent calls to next() are expected to return done: true as well, although this is not enforced on the language level.
throw(exception) Optional
A function that accepts zero or one argument and returns an object conforming to the IteratorResult interface, typically with done equal to true. Calling this method tells the iterator that the caller detects an error condition, and exception is typically an Error instance.
This was referenced Jul 26, 2023
timostamm
approved these changes
Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
WritableIterablebehavior to improve the developer experience. Writes behave as if they are synchronous and resolve when there is one morenextcall (indicating the previous one is processed) or rejected when consumers callthrow.