Fix edge cases with AsyncIterable
protocol
#729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of issues with
AsyncIterable
usage:AsyncIterator
'sreturn
for request iterables. This ensures request iterables are cleaned up properly when server returns early or with an error.Transport
'sstream
method to acceptPartialMessage
instead of concrete ones similar to the unary method. This helps us normalize messages in one place (run-call.ts
).return
/throw
from the response iterables returned by transports/clients.bidi
, start the request as soon as the client calls the method as opposed to waiting for the first read on the response. This is required for Update theWritableIterable
behavior #724 to work properly.