feat: optimistic roots smart contracts #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added necessary changes to allow optimistic mode and slow mode * tests, tests and more tests * natspec Co-authored-by: gotzenx <gotzenx@users.noreply.github.com> Co-authored-by: turtlemoji <turtlemoji@users.noreply.github.com> Co-authored-by: ashitakah <ashitakah@users.noreply.github.com>
LayneHaber
reviewed
Apr 12, 2023
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/connectors/SpokeConnector.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/connectors/SpokeConnector.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/connectors/SpokeConnector.sol
Outdated
Show resolved
Hide resolved
LayneHaber
reviewed
Apr 19, 2023
packages/deployments/contracts/contracts/messaging/libraries/SnapshotId.sol
Outdated
Show resolved
Hide resolved
packages/deployments/contracts/contracts/messaging/RootManager.sol
Outdated
Show resolved
Hide resolved
LayneHaber
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce gas consumption on the message layer to a fraction of the current cost by adding to the system the ability to operate in an optimistic mode when desired.
System will have two modes:
Optimistic ModeandSlow Mode(current one).Optimistic mode is based on an external agent fetching the
inboundRootsand calculating the newaggregateRootoff-chain to propose on the RootManager contract.The propose will have a dispute time where other off-chain agents will have the chance to verify that the proposed data is correct and dispute it if something is not right.
The way we propagate the aggregateRoots will not change.
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Related pull request(s)