-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies as I started fixing multiple things I bumped into while testing this and went a bit outside of the scope. Anyhow, simplified instructions for cross-msgs and beyond, and fixed a few bugs.
Beyond docs, note change to config/mod.rs, which was a bit misleading: our docs use 1234 and the API port and 1234 as the validator port, but the config defaulted to 1234 for the API, which might confuse users. This is more in line with our tutorials.
docs/usage.md
Outdated
@@ -27,6 +27,9 @@ $ ./bin/ipc-agent subnet join --subnet /root/t01002 --collateral 2 --validator-n | |||
``` | |||
This command specifies the subnet to join, the amount of collateral to provide and the validator net address used by other validators to dial them. | |||
|
|||
## Listing your balance in a subnet | |||
> TODO: Add a note on how `wallet list` can be used to check your funds in a subnet. This should be implemented tomorrow (if things go well). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
@jsoares, comments addressed. Feel free to merge if you see they are fine 🙏 |
…pc-agent into adlrocha/cross-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For external consistency in the interface (last-topdown, list-bottomup, but also things like send-value), I think we should reverse the order here. I don't feel very strongly about it but it's my final suggestion -- everything looks and tests good otherwise.
Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
This PR includes some docs for the usage and operation of cross-net messages.