This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Use the same Solidity version #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
LGTM. Are the versions of the rest of the contracts (mainly gateway and subnet actor) the same? Also, a quick sanity-check from @cryptoAtwill before merging, did we have any error by using this version of Solidity? I remember that we had some issue with FEVM not supporting yet the PUSH0 operation.
|
I tried to deploy the contracts over FEVM with the new compiler version and I can confirm that it works. |
adlrocha
added a commit
that referenced
this pull request
Jun 29, 2023
* support f1 address * Fix reentrancy vulnerabilities (#115) Fix reentrancies * Change intro (#118) * Minor gas optimisations (#112) minor gas optimisations * Use logical if statements (#113) use logical if statements * Make gateway address immutable (#110) Make gateway addr immutable * Enable basic linting (#116) * Enable basic linting * add config for mythrill * Run tests on Github Actions (#119) * Run tests * add info * triage findings * rename private vars * fix if statements * Fix reentrancy (#114) * fix reentrancy * Update src/Gateway.sol * add a comment * fix format --------- Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> * Check gateway address (#109) * check gateway address * check subnet address * check actor address * Optimise loop (#123) * Optimise loop * Fix several if stmts * Rename params to fix slither issues * Add codespell (#122) * Remove unused constants and fix Makefile (#121) * remove unused fvm-related constants * fix makefile * Fix bottom-up nonce and new test (#124) fix bottomup nonce and new tets * Use the same Solidity version (#111) use the same Solidity version * Update contract dependencies (#117) * Update contract dependencies * upgrade solidity to 0.8.19 --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> * linter for address * Improved subnet registry (#127) * improved subnet registry * Update SubnetRegistry.sol * Migrate bottom up checkpoints query to subnet actor (#130) migrate bottom up checkpoints query to subnet actor --------- Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: cryptoAtwill <108330426+cryptoAtwill@users.noreply.github.com> --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com>
adlrocha
added a commit
that referenced
this pull request
Jun 29, 2023
* fix gateway deployment * list validator details * update implementation * support configuration number * update logic * support get subnet struct * change visibility * Support f1 address (#107) * support f1 address * Fix reentrancy vulnerabilities (#115) Fix reentrancies * Change intro (#118) * Minor gas optimisations (#112) minor gas optimisations * Use logical if statements (#113) use logical if statements * Make gateway address immutable (#110) Make gateway addr immutable * Enable basic linting (#116) * Enable basic linting * add config for mythrill * Run tests on Github Actions (#119) * Run tests * add info * triage findings * rename private vars * fix if statements * Fix reentrancy (#114) * fix reentrancy * Update src/Gateway.sol * add a comment * fix format --------- Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> * Check gateway address (#109) * check gateway address * check subnet address * check actor address * Optimise loop (#123) * Optimise loop * Fix several if stmts * Rename params to fix slither issues * Add codespell (#122) * Remove unused constants and fix Makefile (#121) * remove unused fvm-related constants * fix makefile * Fix bottom-up nonce and new test (#124) fix bottomup nonce and new tets * Use the same Solidity version (#111) use the same Solidity version * Update contract dependencies (#117) * Update contract dependencies * upgrade solidity to 0.8.19 --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> * linter for address * Improved subnet registry (#127) * improved subnet registry * Update SubnetRegistry.sol * Migrate bottom up checkpoints query to subnet actor (#130) migrate bottom up checkpoints query to subnet actor --------- Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: cryptoAtwill <108330426+cryptoAtwill@users.noreply.github.com> --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes consensus-shipyard/ipc#88