This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Query validator set #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 15, 2023 11:14
…y-actors into main
…y-actors into main
…y-actors into main
adlrocha
previously approved these changes
Jun 20, 2023
src/SubnetActor.sol
Outdated
| @@ -305,7 +311,7 @@ contract SubnetActor is ISubnetActor, ReentrancyGuard, Voting { | |||
|
|
|||
| /// @notice get all the validators in the subnet. | |||
| /// TODO: we can introduce pagination | |||
| function getValidators() external view returns (address[] memory) { | |||
| function getValidators() public view returns (address[] memory) { | |||
There was a problem hiding this comment.
Why changing external to public?
There was a problem hiding this comment.
it's called in the getValidatorsInfo.
There was a problem hiding this comment.
I changed back to external
adlrocha
suggested changes
Jun 20, 2023
| @@ -50,6 +50,9 @@ contract SubnetActor is ISubnetActor, ReentrancyGuard, Voting { | |||
| /// @notice Minimal number of validators required for the subnet to be able to validate new blocks. | |||
| uint64 public immutable minValidators; | |||
|
|
|||
| /// @notice Sequence number that uniquely identifies a validator set. | |||
| uint64 public configurationNumber; | |||
There was a problem hiding this comment.
It would be cleaner to include the configuration number in a struct aggregating all validator information, but I guess for now this is good enough.
There was a problem hiding this comment.
I created that struct, we can migrate to use that struct later
adlrocha
reviewed
Jun 20, 2023
* support f1 address * Fix reentrancy vulnerabilities (#115) Fix reentrancies * Change intro (#118) * Minor gas optimisations (#112) minor gas optimisations * Use logical if statements (#113) use logical if statements * Make gateway address immutable (#110) Make gateway addr immutable * Enable basic linting (#116) * Enable basic linting * add config for mythrill * Run tests on Github Actions (#119) * Run tests * add info * triage findings * rename private vars * fix if statements * Fix reentrancy (#114) * fix reentrancy * Update src/Gateway.sol * add a comment * fix format --------- Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> * Check gateway address (#109) * check gateway address * check subnet address * check actor address * Optimise loop (#123) * Optimise loop * Fix several if stmts * Rename params to fix slither issues * Add codespell (#122) * Remove unused constants and fix Makefile (#121) * remove unused fvm-related constants * fix makefile * Fix bottom-up nonce and new test (#124) fix bottomup nonce and new tets * Use the same Solidity version (#111) use the same Solidity version * Update contract dependencies (#117) * Update contract dependencies * upgrade solidity to 0.8.19 --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> * linter for address * Improved subnet registry (#127) * improved subnet registry * Update SubnetRegistry.sol * Migrate bottom up checkpoints query to subnet actor (#130) migrate bottom up checkpoints query to subnet actor --------- Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: cryptoAtwill <108330426+cryptoAtwill@users.noreply.github.com> --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: Denis Kolegov <dnkolegov@gmail.com> Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com>
Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com>
adlrocha
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List the details of validators and support configuration number.