-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for the main ttrpc project #189
Conversation
Updates the dependencies for the main ttrpc project Signed-off-by: James Sturtevant <jstur@microsoft.com>
The nix dependency is failing due to:
Is this something that should be addressed or should we move back to an older version and address later? |
I think we could adapt the new nix API by using |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 24.39% 24.36% -0.03%
==========================================
Files 17 17
Lines 2529 2532 +3
==========================================
Hits 617 617
- Misses 1912 1915 +3
☔ View full report in Codecov by Sentry. |
@Tim-Zhang I've update to use those API's. Another option instead of boxing the trait would be to refactor some of these functions where |
@jsturtevant I have some suggestions and I've just left a comment |
Adopt new nix API's for SockaddrLike Signed-off-by: James Sturtevant <jstur@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jsturtevant
Updates the dependencies for the main ttrpc project. This is in preparation for a release to include the Windows files in support for projects like the rust shim in containerd/rust-extensions#139