-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release ttrpc: v0.8.0 #190
Conversation
Release ttrpc: v0.8.0. The main feature of this release is support for the Windows Synchronous server and client Signed-off-by: James Sturtevant <jstur@microsoft.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 24.39% 24.39%
=======================================
Files 17 17
Lines 2529 2529
=======================================
Hits 617 617
Misses 1912 1912
☔ View full report in Codecov by Sentry. |
@Tim-Zhang @lifupan @wllenyj Any thoughts on a release? |
LGTM |
@jsturtevant Should we merge |
I was thinking a release with the depreciated function in it with If it is preferable to remove the function from one release to the next then let me know and I can drop it. |
@jsturtevant In my opinion, I prefer to remove the [deprecated] method and rename new_from_fd to new. The release is a major release so we don't need to consider compatible issues. |
opened #191 |
@Tim-Zhang @mxpv Is there an additional step to release the crate? I am not seeing it on crates.io |
@Tim-Zhang @lifupan can you guys help with the new crate release? |
@jsturtevant @mxpv I have just released the version: https://crates.io/crates/ttrpc/0.8.0, sorry to be a bit slow to do it. |
Thanks! Would some automation help here? We recently automated this in Runwasi (https://github.com/containerd/runwasi/blob/main/.github/workflows/release.yml). Might help with long term maintenance |
Release ttrpc: v0.8.0. The main feature of this release is support for the Windows Synchronous server and client
This allows usage in projects like containerd/rust-extensions#139
note
I don't know the projects release process but was hoping to start the conversation here. I am happy to help document the process as well.
Leaving in draft until #189 merges