Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ttrpc: v0.8.0 #190

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Release ttrpc: v0.8.0 #190

merged 1 commit into from
Jun 14, 2023

Conversation

jsturtevant
Copy link
Collaborator

Release ttrpc: v0.8.0. The main feature of this release is support for the Windows Synchronous server and client

This allows usage in projects like containerd/rust-extensions#139

note

I don't know the projects release process but was hoping to start the conversation here. I am happy to help document the process as well.

Leaving in draft until #189 merges

Release ttrpc: v0.8.0. The main feature of this release is support for the Windows Synchronous server and client

Signed-off-by: James Sturtevant <jstur@microsoft.com>
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dde3298) 24.39% compared to head (35a1337) 24.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   24.39%   24.39%           
=======================================
  Files          17       17           
  Lines        2529     2529           
=======================================
  Hits          617      617           
  Misses       1912     1912           
Impacted Files Coverage Δ
src/error.rs 55.55% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsturtevant
Copy link
Collaborator Author

@Tim-Zhang @lifupan @wllenyj Any thoughts on a release?

@wllenyj
Copy link
Collaborator

wllenyj commented May 23, 2023

LGTM

@jsturtevant jsturtevant marked this pull request as ready for review May 27, 2023 18:00
@jsturtevant jsturtevant requested a review from Tim-Zhang May 27, 2023 18:00
@Tim-Zhang
Copy link
Member

@jsturtevant Should we merge Client::new_from_fd and Client::new methods before this mojor bump?

@jsturtevant
Copy link
Collaborator Author

@jsturtevant Should we merge Client::new_from_fd and Client::new methods before this mojor bump?

I was thinking a release with the depreciated function in it with [deprecated] tag allows folks to upgrade versions on their time without changes. In the next version we could remove the depreciated function giving one release to make the change.

If it is preferable to remove the function from one release to the next then let me know and I can drop it.

@Tim-Zhang
Copy link
Member

Tim-Zhang commented Jun 5, 2023

@jsturtevant In my opinion, I prefer to remove the [deprecated] method and rename new_from_fd to new. The release is a major release so we don't need to consider compatible issues.

@jsturtevant
Copy link
Collaborator Author

@jsturtevant In my opinion, I prefer to remove the [deprecated] method and rename new_from_fd to new. The release is a major release so we don't need to consider compatible issues.

opened #191

@mxpv mxpv merged commit b13d3fd into containerd:master Jun 14, 2023
@jsturtevant
Copy link
Collaborator Author

@Tim-Zhang @mxpv Is there an additional step to release the crate? I am not seeing it on crates.io

@mxpv
Copy link
Member

mxpv commented Jun 15, 2023

@Tim-Zhang @lifupan can you guys help with the new crate release?

@Tim-Zhang
Copy link
Member

@jsturtevant @mxpv I have just released the version: https://crates.io/crates/ttrpc/0.8.0, sorry to be a bit slow to do it.

@jsturtevant
Copy link
Collaborator Author

Thanks! Would some automation help here? We recently automated this in Runwasi (https://github.com/containerd/runwasi/blob/main/.github/workflows/release.yml). Might help with long term maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants